Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic route fix #1130

Merged
merged 9 commits into from
Apr 27, 2022
Merged

fix: dynamic route fix #1130

merged 9 commits into from
Apr 27, 2022

Conversation

summer-ji-eng
Copy link
Collaborator

@summer-ji-eng summer-ji-eng commented Apr 23, 2022

Now generator only works for multiple variables in HTTP URI in format like {param1.param2.param3=abc/*/d/*/ef/}. It doesn't support format in /v1/projects/{project_id}/locations/{location}/jobs.

dataflow proto has recent change. Because generator only find the first HTTP request param project_id(client library code), it cause loctation error. The reason is that the routing header misses location to sent x-goog-request-param header in grpc matedata.

To sent the correct the http request parameter, the client library surface code should has change like this:

options.otherArgs.headers['x-goog-request-params'] =
      gax.routingHeader.fromParams({
        project_id: request.projectId || '',
        location: request.location || '',
      });

@summer-ji-eng summer-ji-eng changed the title fix: dynamic rout fix fix: dynamic route fix Apr 23, 2022
@summer-ji-eng summer-ji-eng marked this pull request as ready for review April 25, 2022 19:46
@summer-ji-eng summer-ji-eng requested a review from a team as a code owner April 25, 2022 19:46
@summer-ji-eng summer-ji-eng requested review from alexander-fenster and removed request for alexander-fenster April 25, 2022 19:46
@summer-ji-eng
Copy link
Collaborator Author

Test should pass once #1132 merged.

@summer-ji-eng summer-ji-eng added the automerge Merge the pull request once unit tests and other checks pass. label Apr 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit e6cd782 into main Apr 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the dynamic_route_fix branch April 27, 2022 21:18
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 27, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 27, 2022
🤖 I have created a release *beep* *boop*
---


### [2.14.3](v2.14.2...v2.14.3) (2022-04-27)


### Bug Fixes

* dynamic route fix ([#1130](#1130)) ([e6cd782](e6cd782))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants