The location option of launchFlexTemplate is not working

[holyshared]

The location option of launchFlexTemplate is not working

I created a dataflow job with asia-northeast1 as the location of the launchFlexTemplate.
However, the job region becomes us-central1.

The code I'm trying is below.

import { FlexTemplatesServiceClient } from "@google-cloud/dataflow"

const client = new FlexTemplatesServiceClient({
  projectId: process.env.GCP_PROJECT_ID,
})

client.launchFlexTemplate({
  projectId: process.env.GCP_PROJECT_ID,
  location: process.env.GCP_REGION,
  launchParameter: {
    jobName: "example-job",
    containerSpecGcsPath: process.env.GCP_CONTAINER_SPEC_PATH,
    parameters: {
      input: "gs://bucket/input/input.json",
      output: "gs://bucket/output/output.json",
    },
    environment: {
      subnetwork: process.env.GCP_SUBNETWORK,
      serviceAccountEmail: process.env.GCP_SERVICE_ACCOUNT_EMAIL,
    }
  }
}).then(([res, req]) => {
  console.log("job %s created", res.job.name)
}).catch(err => {
  console.log(err.stack)
})

Environment details

• OS: macOS Big Sur 11.4
• Node.js version: v14.4.0
• npm version: 6.14.5
• @google-cloud/dataflow version: 1.0.2

[meredithslota]

We've identified similar issues in other repos and have escalated this to the API service team since it's not a language-specific library issue. Here are the related issues:

• ListJobsRequest is not using the 'location' filter python-dataflow-client#31: ListJobsRequest is not using the 'location' filter
• Support for locations in the launch_template method python-dataflow-client#25: Support for locations in the launch_template method
• The location option of launchFlexTemplate is not working #19: The location option of launchFlexTemplate is not working
• https://github.com/googleapis/java-dataflow/issues/64: Dataflow: The location field of LaunchFlexTemplateRequest building is not working
• ListJobsAsync() returns only us-central1 jobs google-cloud-dotnet#7038: ListJobsAsync() returns only us-central1 jobs (context from issue is that the location parameter isn't working)

Marking this as a P1 bug w/ external label.

[bbhoss]

I couldn't find an existing issue in the Google Issue Tracker so I created one here. I suggest starring this issue to anyone else that runs across this problem, hopefully it will get some attention from Google soon.

[rafaeldl]

I think we solved the problem, now we have to test! https://github.com/googleapis/nodejs-dataflow/pull/44

[meredithslota]

This does appear to have been rolled out, at least in the Node.js libraries, in #44 — can someone in this thread (@rafaeldl or @bbhoss or @holyshared) confirm if this is working for you now?

[rafaeldl]

@meredithslota I'm waiting for the release 1.2.0 #45 . But it lacks some approval for the release. :(

[meredithslota]

Thanks for flagging that — I requested a review and it looks like it's gone through now. Can you check with the latest version?

[meredithslota]

@rafaeldl Can you see if the issue is resolved for you with the latest version of the library? It's been released. We're seeing success in other libraries (e.g. this appears fixed in the Python client) just want to validate the Node.js client is working as expected now as well. Thanks!

[meredithslota]

We are pretty confident that this is nearly fully resolved (another related issue was just fixed: googleapis/gapic-generator-typescript#1133 and should be rolling out shortly) and just needs to make its way into this library. Should happen shortly.

[davidcavazos]

The fix has been merged on PR googleapis/gapic-generator-typescript#1130 and it should be available on release 2.14.3 or later.

I'm closing this, but please re-open if the issue still persists.