fix: proper processing of routing headers #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
force-pushed
the
fix-routing
branch
from
fee267d
to
396217a
Compare
sofisl
reviewed
Jul 19, 2022
sofisl
approved these changes
Jul 19, 2022
alexander-fenster
force-pushed
the
fix-routing
branch
from
fd2fed7
to
ed45325
Compare
alexander-fenster
force-pushed
the
fix-routing
branch
from
ed45325
to
c299ad2
Compare
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
🤖 I have created a release *beep* *boop* --- ## [2.15.3](v2.15.2...v2.15.3) (2022-07-20) ### Bug Fixes * proper processing of routing headers ([#1160](#1160)) ([6e9f77f](6e9f77f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1154.
A huge refactor of the routing header processing logic to fix the Cloud Run use case. Tested locally, the generated Cloud Run client works (successfully providing the
locationrouting header).