fix: remove LRO mixin if there are no LRO methods #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
approved these changes
Sep 16, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
🤖 I have created a release *beep* *boop* --- ## [2.18.0](v2.17.0...v2.18.0) (2022-09-20) ### Features * An option to override mixins ([#1266](#1266)) ([2546855](2546855)) ### Bug Fixes * Remove LRO mixin if there are no LRO methods ([#1262](#1262)) ([2d28ae4](2d28ae4)) * Use fully qualified request type name in tests ([#1267](#1267)) ([238156e](238156e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include LRO mixin methods if an API service yaml enables LRO mixin, but the API does not actually have any LRO methods.
The main code change is in proto.ts, others are just the baseline changes.
Note that this change might be breaking for APIs that have more than one client but only one of those clients have LRO methods. The current implementation will add
GetOperationand such to all clients. The changed Showcase baselines show that. I will send a separate PR to have a break glass generator option overriding the list of mixins that I will later use to avoid the possible breaking changes to such APIs.