fix: small esm fixes and add esm-system tests #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
force-pushed
the
addCompilationTestToEsm
branch
from
91de320
to
f58ee2a
Compare
sofisl
changed the title
| @@ -55,9 +55,10 @@ | |||
| "test:esm": "c8 mocha build/esm/test", | |||
| "test": "npm run test:cjs && npm run test:esm", | |||
| "compile:esm": "tsc -p ./tsconfig.esm.json", | |||
| "babel": "babel esm --out-dir build/cjs --extensions \".ts\" --out-file-extension .cjs --copy-files", | |||
| "babel": "babel esm --out-dir build/cjs --ignore \"esm/**/*.d.ts\" --extensions \".ts\" --out-file-extension .cjs --copy-files", | |||
There was a problem hiding this comment.
Note that these changes will only apply to new libraries, we'll need to make these changes separately for package.json files for existing libraries.
| "c8": "^8.0.1", | ||
| "gapic-tools": "^0.2.0", | ||
| "gts": "5.2.0", | ||
| "gts": "^5.2.0", |
There was a problem hiding this comment.
Is this intentional to unpin it?
alexander-fenster
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.