fix: the return type from IAM method promises should be an array #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
alexander-fenster
approved these changes
May 10, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
|
I believe this needs to be reevaluated now that we support IAM mix-in. I'll close this for now. |
|
@alexander-fenster We're trying to get the gax side of this in for the new major - can we do that re-evaluation on this? I'm not sure what IAM mixins are. Also @sofisl who's doing the Node 14 work. |
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
This PR is out of date now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for this issue on nodejs-pubsub: googleapis/gax-nodejs#1460
@alexander-fenster This is the thing we talked about in chat :)