This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Python: Add routing header #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1658 +/- ##
=========================================
Coverage ? 84.98%
Complexity ? 4383
=========================================
Files ? 425
Lines ? 17452
Branches ? 1822
=========================================
Hits ? 14831
Misses ? 2004
Partials ? 617
Continue to review full report at Codecov.
|
saicheems
reviewed
Oct 30, 2017
| import java.util.List; | ||
|
|
||
| public class HeaderRequestParamTransformer { | ||
| public List<HeaderRequestParamView> generateHeaderRequestParams(MethodContext context) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…ython-routing-header
lukesneeringer
suggested changes
Nov 2, 2017
| @@ -329,3 +345,25 @@ | |||
| {@param.keyName}={@param.name} | |||
| @end | |||
| @end | |||
|
|
|||
| @private routingHeader(params) | |||
| b'{@routingHeaderFmtStr(params)}'.format({@routingHeaderFmtArgs(params)}) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return self._create_book(request, retry=retry, timeout=timeout) | ||
|
|
||
| metadata = [ | ||
| (b'x-google-request-params', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Nov 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related api_core PR: googleapis/google-cloud-python#4336