This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
feat: Add opt_args to common_proto_library. #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to suport <plugin_name>_opt command line args for protoc with a <plugin>.
googlebot
added
the
cla: yes
vam-google
added a commit
to vam-google/gapic-generator-python
that referenced
this pull request
May 8, 2020
This is to suport <plugin_name>_opt command line args for protoc with a <plugin>. See googleapis#390 for more details. This PR depends on googleapis/gapic-generator#3191
Codecov Report
@@ Coverage Diff @@
## master #3191 +/- ##
=========================================
Coverage 87.13% 87.13%
Complexity 6075 6075
=========================================
Files 494 494
Lines 24039 24039
Branches 2610 2610
=========================================
Hits 20946 20946
Misses 2232 2232
Partials 861 861 Continue to review full report at Codecov.
|
noahdietz
approved these changes
May 8, 2020
software-dov
approved these changes
May 8, 2020
vam-google
added a commit
to googleapis/gapic-generator-python
that referenced
this pull request
May 8, 2020
This is to suport <plugin_name>_opt command line args for protoc with a <plugin>. See #390 for more details. This PR depends on googleapis/gapic-generator#3191 Example of usage: ```bzl py_gapic_library( name = "documentai_py_gapic", srcs = [":documentai_proto"], opt_args = [ "old-naming", "lazy-import", "python-gapic-name=documentai", "python-gapic-templates=ads-templates", ], ) ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to suport
<plugin_name>_optcommand line args forprotocwith a<plugin>.