chore: add special characters to testing.proto comments#1391
Conversation
|
LGTM, but would like to have a showcase-go team member review. |
|
QQ: Is there a reason why this is added as a showcase change instead of a unit test/ integration test inside the Java Generator? I think this could also been caught with a test to the I'm not opposed since updating here could also help other languages catch the same issue. |
I agree, I think we should test it in both unit tests and showcase tests, for the exact same reason you mentioned. Not integration tests though as it is dependent on the actual service protos which we don't control. |
I will look to add a test in googleapis/sdk-platform-java#2280. In the meantime, @noahdietz / @vchudnov-g ; let us know if you have any concerns about the addition of these comments to the showcase test. Thanks! |
noahdietz
left a comment
There was a problem hiding this comment.
I personally don't have a problem with this. We can find out if some of the more markdown-sensitive languages (Python, C# I think) will dislike this though.
I'd say go ahead and we can find out!
Adding some proto comments to both a service and RPC that contain special characters. This is to help catch generator formatting issues. (e.g. googleapis/sdk-platform-java#2280)