Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use io.ReadAll #1520

Merged
merged 3 commits into from
Jul 3, 2024
Merged

fix: use io.ReadAll #1520

merged 3 commits into from
Jul 3, 2024

Conversation

burkedavison
Copy link
Member

Attempting fix for #1519

@burkedavison
Copy link
Member Author

Updates based on description of #1519.

Checks don't seem to be validating this part of the code:
image

@burkedavison
Copy link
Member Author

Manually verify working with Java 21 showcase client integration tests.

@burkedavison burkedavison marked this pull request as ready for review July 3, 2024 14:03
@burkedavison burkedavison requested review from a team as code owners July 3, 2024 14:03
@burkedavison burkedavison merged commit 6dddadd into main Jul 3, 2024
10 of 11 checks passed
@burkedavison burkedavison deleted the use-io-readall branch July 3, 2024 19:58
@release-please release-please bot mentioned this pull request Jul 3, 2024
Merged
vchudnov-g
vchudnov-g reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lqiu96 lqiu96 mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g left review comments

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burkedavison @vchudnov-g @codyoss