Skip to content

Commit

Permalink
fix(v2): drop cloud lro test dep (#276)
Browse files Browse the repository at this point in the history
Fixes #270
  • Loading branch information
noahdietz authored May 23, 2023
1 parent b9f419c commit c67eeba
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
1 change: 0 additions & 1 deletion v2/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ require (
)

require (
cloud.google.com/go/longrunning v0.4.1 // indirect
github.com/golang/protobuf v1.5.3 // indirect
golang.org/x/net v0.9.0 // indirect
golang.org/x/sys v0.7.0 // indirect
Expand Down
2 changes: 0 additions & 2 deletions v2/go.sum
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
cloud.google.com/go/longrunning v0.4.1 h1:v+yFJOfKC3yZdY6ZUI933pIYdhyhV8S3NpWrXWmg7jM=
cloud.google.com/go/longrunning v0.4.1/go.mod h1:4iWDqhBZ70CvZ6BfETbvam3T8FMvLK+eFj0E6AaRQTo=
github.com/golang/protobuf v1.5.0/go.mod h1:FsONVRAS9T7sI+LIUmWTfcYkHO4aIWwzhcaSAoJOfIk=
github.com/golang/protobuf v1.5.3 h1:KhyjKVUg7Usr/dYsdSqoFveMYd5ko72D+zANwlG1mmg=
github.com/golang/protobuf v1.5.3/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY=
Expand Down
19 changes: 12 additions & 7 deletions v2/proto_json_stream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ import (

"github.com/google/go-cmp/cmp"
serviceconfigpb "google.golang.org/genproto/googleapis/api/serviceconfig"
"google.golang.org/genproto/googleapis/longrunning"
"google.golang.org/genproto/googleapis/rpc/code"
"google.golang.org/genproto/googleapis/rpc/status"
"google.golang.org/protobuf/encoding/protojson"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/reflect/protoreflect"
Expand Down Expand Up @@ -72,13 +73,17 @@ func TestRecv(t *testing.T) {
durationpb.New(time.Hour),
}

md, _ := anypb.New(locations[0])

detail, err := anypb.New(locations[0])
if err != nil {
t.Fatal(err)
}
nested := []proto.Message{
&longrunning.Operation{
Name: "foo",
Done: true,
Metadata: md,
&status.Status{
Code: int32(code.Code_INTERNAL),
Message: "oops",
Details: []*anypb.Any{
detail,
},
},
}

Expand Down

0 comments on commit c67eeba

Please sign in to comment.