fix(v2): handle space in non-devel go version (#288)

googleapis · Jun 13, 2023 · fd7bca0 · fd7bca0
1 parent 67efbd3
commit fd7bca0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/v2/header.go b/v2/header.go
@@ -66,6 +66,8 @@ func goVersion() string {
 			s = s[:p]
 		}
 		return s
+	} else if p := strings.IndexFunc(s, unicode.IsSpace); p >= 0 {
+		s = s[:p]
 	}
 
 	notSemverRune := func(r rune) bool {

diff --git a/v2/header_test.go b/v2/header_test.go
@@ -77,6 +77,10 @@ func TestGoVersion(t *testing.T) {
 			testVersion("this should be unknown"),
 			versionUnknown,
 		},
+		{
+			testVersion("go1.21-20230101-RC01 cl/1234567 +abc1234"),
+			"1.21.0-20230101-RC01",
+		},
 	} {
 		version = tst.v
 		got := goVersion()