Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2/apierror): return Unknown GRPCStatus when err source is HTTP #260

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix(v2/apierror): return Unknown GRPCStatus when err source is HTTP #260

merged 1 commit into from
Mar 3, 2023

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Mar 3, 2023

  • return Unknown status when googleapi.Error because gRPC treats nil as OK

closes: #254

@quartzmo
fix(v2/apierror): return Unknown GRPCStatus when err source is HTTP
f611561 
* return Unknown status when googleapi.Error because gRPC treats nil as OK

closes: googleapis#254
@quartzmo quartzmo requested a review from a team as a code owner March 3, 2023 22:57
@quartzmo quartzmo merged commit 043b734 into googleapis:main Mar 3, 2023
@quartzmo quartzmo deleted the apierror-fix-status branch March 3, 2023 23:58
@release-please release-please bot mentioned this pull request Mar 3, 2023
Merged
@quartzmo quartzmo mentioned this pull request Mar 9, 2023
Open
@rahul2393 rahul2393 mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APIError.GRPCStatus returns "OK" for all http errors.
2 participants
@quartzmo @noahdietz