Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): fix TestRetryInfoTransactionOutcomeUnknownError flaky behaviour #7959

Merged
merged 1 commit into from
May 18, 2023

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented May 18, 2023

Fixes: #7887

toSpannerErrorWithCommitInfo returns *gax-go.ApiError after the changes googleapis/gax-go#260, this PR will fix the flaky issue because of this

@rahul2393 rahul2393 requested review from a team as code owners May 18, 2023 06:15
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the Spanner API. labels May 18, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 18, 2023
@rahul2393 rahul2393 merged commit f037795 into main May 18, 2023
@rahul2393 rahul2393 deleted the fix_flaky_issue branch May 18, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: TestRetryInfoTransactionOutcomeUnknownError failed
2 participants