Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iterator): add package to help work with new iter.Seq types #358

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jun 28, 2024

This package is meant to be used to adapt our existing iterators into type that can be consumed by Go's range expressions. See example for usage. Note this feature requires Go1.23+ and was tested with go1.23rc1.

This package is meant to be used to adapt our existing iterators
into type that can be consumed by Go's range expressions. See
example for usage. Note this feature requires Go1.23+ and was
tested with go1.23rc1.
@codyoss codyoss requested a review from a team as a code owner June 28, 2024 17:28
codyoss added a commit to codyoss/gapic-generator-go that referenced this pull request Jun 28, 2024
This changes starts generating build tag protected adapters for
using our iterator types in Go range expressions.

Related: googleapis/gax-go#358
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@noahdietz noahdietz changed the title feat(iter): add package to help work with new iter.Seq types feat(iterator): add package to help work with new iter.Seq types Jul 22, 2024
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6bccdaa into googleapis:main Jul 22, 2024
4 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2024
codyoss added a commit to googleapis/gapic-generator-go that referenced this pull request Aug 16, 2024
This changes starts generating build tag protected adapters for using our iterator types in Go range expressions.

Related: googleapis/gax-go#358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants