make v1 a type alias of v2, add go.mod #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supercedes googleapis#58 and follows googleapis#59, and is the second of two in a series of commits to add Go module support to gax. This commit makes v1 code type aliases of v2 code. This commit will be tagged v1.0.1. Reasoning for making type aliases: Users are directly exposed to exported types in this package such as CallOption. google-cloud-go will rely on v2 of gax, but a user's codebase is still going to have the non-v2/ gax import paths. We could: - Make google-cloud-go rely on v2 and simultaneously create a v2 of google-cloud-go. All existing users of google-cloud-go continue using v1 of gax and v1 of google-cloud-go. All folks migrating to v2 of google-cloud-go must go update their gax import paths to use /v2. (this is obviously infeasible) - Make all gax v1 types aliases of gax v2 types, and all v1 functions shadows of v2 functions. That way, google-cloud-go can rely on v2 but a user can pass either a v1 or v2 gax type.
googlebot
added
the
cla: yes
jba
reviewed
Nov 13, 2018
jeanbza
changed the title
|
I've added a go.mod. One thing that was somewhat surprising was that the go.mod of the parent does not seem to require a |
|
This does not at all meet my expectations 😆 I'm unsure who has the authoritative answer though :/ |
I've created golang/go#28801. |
bcmills
reviewed
Nov 15, 2018
|
This LGTM. Does |
|
Sorry, I really should have called that out. Actually, the |
|
+1, thanks @bcmills for the look-over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit supercedes #58 and follows #59, and is the second of two in a
series of commits to add Go module support to gax.
This commit makes v1 code type aliases of v2 code. This commit will be tagged
v1.0.1.
Reasoning for making type aliases:
Users are directly exposed to exported types in this package such as
CallOption. google-cloud-go will rely on v2 of gax, but a user's codebase is
still going to have the non-v2/ gax import paths.
We could:
google-cloud-go. All existing users of google-cloud-go continue using v1 of
gax and v1 of google-cloud-go. All folks migrating to v2 of google-cloud-go
must go update their gax import paths to use /v2. (this is obviously
infeasible)
of v2 functions. That way, google-cloud-go can rely on v2 but a user can pass
either a v1 or v2 gax type.