This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
fix: Watchdog does not does not wait for executor to shutdown on awaitTermination #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng if the executor is provided by ExecutorProvider.
blakeli0
commented
Nov 30, 2022
|
Kudos, SonarCloud Quality Gate passed! |
blakeli0
changed the title
| } | ||
|
|
||
| @Override | ||
| public void shutdownNow() { | ||
| future.cancel(true); | ||
| // Unregister the main thread | ||
| phaser.arriveAndDeregister(); |
There was a problem hiding this comment.
Might be good to avoid double calls:
if (future.cancel(true)) {
phaser.arriveAndDeregister();
}
| @@ -134,26 +143,37 @@ private void runUnsafe() { | |||
| @Override | |||
| public void shutdown() { | |||
| future.cancel(false); | |||
| // Unregister the main thread | |||
| phaser.arriveAndDeregister(); | |||
There was a problem hiding this comment.
Might be good to avoid double calls:
if (future.cancel(true)) {
phaser.arriveAndDeregister();
}
igorbernstein2
approved these changes
Jan 11, 2023
meltsufin
added
the
do not merge
|
@igorbernstein2 I don't think this PR is still relevant because we went with: #1890. But we can wait for @blakeli0 to confirm. Update: I see it was planned as a further improvement to #1890. So never mind. |
|
Closing this in favor of googleapis/sdk-platform-java#1337 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1858
Watchdog does not wait for executor to shutdown on awaitTermination. Instead, use
Phaserto track the lifecycle of eachrun()execution, wait for thePhaserto proceed to next phase(which is terminated phase in our case) inawaitTerminationand usephaser.isTerminated()to determine if Watchdog is terminated or not.