Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Bundling restructure #226

Conversation

michaelbausor
Copy link
Contributor

Replaces #214

@codecov-io
Copy link

codecov-io commented Mar 4, 2017

Codecov Report

Merging #226 into bundling-flowcontrol-branch will decrease coverage by -0.21%.
The diff coverage is 83.83%.

@@                       Coverage Diff                       @@
##             bundling-flowcontrol-branch   #226      +/-   ##
===============================================================
- Coverage                           70.2%    70%   -0.21%     
- Complexity                           483    485       +2     
===============================================================
  Files                                 67     68       +1     
  Lines                               2541   2557      +16     
  Branches                             267    267              
===============================================================
+ Hits                                1784   1790       +6     
- Misses                               659    669      +10     
  Partials                              98     98
Impacted Files Coverage Δ Complexity Δ
...e/api/gax/bundling/AccumulatingBundleReceiver.java 83.33% <100%> (ø) 3 <1> (ø)
.../com/google/api/gax/bundling/ThresholdBundler.java 96.55% <100%> (-0.03%) 27 <0> (-1)
...java/com/google/api/gax/grpc/BundlingCallable.java 88.88% <100%> (ø) 3 <0> (ø)
...n/java/com/google/api/gax/grpc/BundleExecutor.java 100% <100%> (ø) 5 <2> (-1)
src/main/java/com/google/api/gax/grpc/Bundle.java 55% <55%> (ø) 4 <4> (?)
...n/java/com/google/api/gax/grpc/BundlerFactory.java 78.46% <73.68%> (-1.87%) 12 <9> (+1)
.../com/google/api/gax/grpc/BundledRequestIssuer.java 78.94% <75%> (ø) 6 <2> (?)
...e/api/gax/bundling/ThresholdBundlingForwarder.java 87.5% <83.33%> (ø) 4 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3ced6...4648c8c. Read the comment docs.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after doc stuff is addressed.

@@ -132,22 +138,22 @@ private Builder() {
public void add(E e) throws FlowControlException {
final Lock lock = this.lock;
// We need to reserve resources from flowController outside the lock, so that they can be
// released by drainNextBundleTo().
// released by takeBundle().

This comment was marked as spam.

import java.util.ArrayList;
import java.util.List;

public class Bundle<RequestT, ResponseT> {

This comment was marked as spam.

@michaelbausor michaelbausor merged commit b574354 into googleapis:bundling-flowcontrol-branch Mar 5, 2017
@michaelbausor michaelbausor deleted the bundling-restructure branch March 5, 2017 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants