This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 119
Bundling restructure #226
Merged
michaelbausor
merged 9 commits into
googleapis:bundling-flowcontrol-branch
from
michaelbausor:bundling-restructure
Mar 5, 2017
Merged
Bundling restructure #226
michaelbausor
merged 9 commits into
googleapis:bundling-flowcontrol-branch
from
michaelbausor:bundling-restructure
Mar 5, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## bundling-flowcontrol-branch #226 +/- ##
===============================================================
- Coverage 70.2% 70% -0.21%
- Complexity 483 485 +2
===============================================================
Files 67 68 +1
Lines 2541 2557 +16
Branches 267 267
===============================================================
+ Hits 1784 1790 +6
- Misses 659 669 +10
Partials 98 98
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after doc stuff is addressed.
@@ -132,22 +138,22 @@ private Builder() { | |||
public void add(E e) throws FlowControlException { | |||
final Lock lock = this.lock; | |||
// We need to reserve resources from flowController outside the lock, so that they can be | |||
// released by drainNextBundleTo(). | |||
// released by takeBundle(). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
public class Bundle<RequestT, ResponseT> { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #214