Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Fix a bug that cause local test helper to fail when searching an emulator with an older cloud SDK #33

Merged
merged 1 commit into from
Mar 28, 2016

Conversation

aozarov
Copy link
Contributor

@aozarov aozarov commented Mar 23, 2016

currentVersion may be null when using an older GCLOUD SDK without the searched emulator.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@garrettjonesgoogle
Copy link
Member

/cc @shinfan

@garrettjonesgoogle
Copy link
Member

That's odd that googlebot doesn't recognize your CLA status...

currentVersion may be null when using an older GCLOUD SDK without the searched emulator.
@googlebot
Copy link

CLAs look good, thanks!

@aozarov
Copy link
Contributor Author

aozarov commented Mar 23, 2016

That's odd that googlebot doesn't recognize your CLA status...

I created this PR directly via the Github UI which used, aozarov@users.noreply.github.com, as the Author. I fixed that by amending the commit.

@aozarov
Copy link
Contributor Author

aozarov commented Mar 26, 2016

ping.

Was this issue fixed in a different PR? We need to get it in for fixing the gcloud-java pubsub-alpha branch build.

@shinfan
Copy link
Contributor

shinfan commented Mar 27, 2016

LGTM. Thanks for catching & fixing the issue.

@aozarov
Copy link
Contributor Author

aozarov commented Mar 27, 2016

I don't have permission to merge for this repository.
I built it locally and it looks fine. Do you mind to merge and create a new release with this fix?

BTW, I highly recommend configuring Travis for this project to build every PR, so you can be sure
that it builds before you merge.

@shinfan shinfan merged commit 6386e6f into googleapis:master Mar 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants