Skip to content

Commit

Permalink
fix: don't retry server streaming calls if retryCodes is the empty ar…
Browse files Browse the repository at this point in the history 
…ray (#1578)

* get branch in sync with upstream main

* feat: update server streaming retries
Squashed commit of the following:

commit 195540efe2e84c2e155f0259afae3edce104a40b
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 16:34:36 2023 -0400

    resolve some warnings

commit 6e4311c0ce0fabe12755b8268c23f2b5e249bbca
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 16:28:37 2023 -0400

    fix last error (now just warnings!)

commit d729f28bb882e0d85629c57ab369df31f2ec8e26
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 16:22:39 2023 -0400

    fix no-async-promise-executor lint errors

commit 087944aeb505f326a56e829155414116b31ac813
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 14:59:23 2023 -0400

    fix more lint things (more to come)

commit 5d2be7aad8ed46d41facae9b2211f0740346ce97
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 14:19:40 2023 -0400

    add missing retry-request related dependency

commit fd811e370a7784ea9d3367f00bdea4faabdafb61
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 14:17:19 2023 -0400

    fix some lint issues (more to come)

commit 94b5a37c03e01e91a5e42a1bbf19767711b271d0
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 14:02:07 2023 -0400

    npm run fix and remove todo

commit 0acc287a089b11b044453788a9df1220645b504f
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 14:00:43 2023 -0400

    add missing license headers

commit 8535c29cda942f4f0319527fc791f2becbae417c
Merge: 8cb5718 b322f78
Author: Alexander Fenster <fenster@google.com>
Date:   Tue Aug 22 10:56:33 2023 -0700

    Merge branch 'main' into gax4upgrade-2

commit 8cb5718e41e9010bf1dcfabb53bda1dea2239e77
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 22 10:51:14 2023 -0400

    remove todos

commit b322f784ec7768e0da781fd54ea5bc9d2347c8cd
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Tue Aug 22 13:10:13 2023 +0200

    chore(deps): update dependency protobufjs to v7.2.5 (#1494)

    [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

    This PR contains the following updates:

    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [protobufjs](https://protobufjs.github.io/protobuf.js/) ([source](https://togithub.com/protobufjs/protobuf.js)) | [`7.2.4` -> `7.2.5`](https://renovatebot.com/diffs/npm/protobufjs/7.2.4/7.2.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/protobufjs/7.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/protobufjs/7.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/protobufjs/7.2.4/7.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/protobufjs/7.2.4/7.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

    ---

    ### Release Notes

    <details>
    <summary>protobufjs/protobuf.js (protobufjs)</summary>

    ### [`v7.2.5`](https://togithub.com/protobufjs/protobuf.js/blob/HEAD/CHANGELOG.md#725-2023-08-21)

    [Compare Source](https://togithub.com/protobufjs/protobuf.js/compare/protobufjs-v7.2.4...protobufjs-v7.2.5)

    ##### Bug Fixes

    -   crash in comment parsing ([#&#8203;1890](https://togithub.com/protobufjs/protobuf.js/issues/1890)) ([eaf9f0a](https://togithub.com/protobufjs/protobuf.js/commit/eaf9f0a5a4009a8981c69af78365dfc988ed925b))
    -   deprecation warning for new Buffer ([#&#8203;1905](https://togithub.com/protobufjs/protobuf.js/issues/1905)) ([e93286e](https://togithub.com/protobufjs/protobuf.js/commit/e93286ef70d2e673c341ac08a192cc2abe6fd2eb))
    -   possible infinite loop when parsing option ([#&#8203;1923](https://togithub.com/protobufjs/protobuf.js/issues/1923)) ([f2a8620](https://togithub.com/protobufjs/protobuf.js/commit/f2a86201799af5842e1339c22950abbb3db00f51))

    </details>

    ---

    ### Configuration

    📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

    ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

    🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

    ---

     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

    ---

    This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/gax-nodejs).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

commit 762591ed28801e5311ab737b04185781a41752e6
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Tue Aug 22 12:56:13 2023 +0200

    fix(deps): update dependency protobufjs-cli to v1.1.2 (#1495)

    [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

    This PR contains the following updates:

    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [protobufjs-cli](https://togithub.com/protobufjs/protobuf.js) | [`1.1.1` -> `1.1.2`](https://renovatebot.com/diffs/npm/protobufjs-cli/1.1.1/1.1.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/protobufjs-cli/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/protobufjs-cli/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/protobufjs-cli/1.1.1/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/protobufjs-cli/1.1.1/1.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

    ---

    ### Release Notes

    <details>
    <summary>protobufjs/protobuf.js (protobufjs-cli)</summary>

    ### [`v1.1.2`](https://togithub.com/protobufjs/protobuf.js/releases/tag/protobufjs-cli-v1.1.2): protobufjs-cli: v1.1.2

    [Compare Source](https://togithub.com/protobufjs/protobuf.js/compare/protobufjs-cli-v1.1.1...protobufjs-cli-v1.1.2)

    ##### Bug Fixes

    -   possible infinite loop when parsing option ([#&#8203;1923](https://togithub.com/protobufjs/protobuf.js/issues/1923)) ([f2a8620](https://togithub.com/protobufjs/protobuf.js/commit/f2a86201799af5842e1339c22950abbb3db00f51))

    </details>

    ---

    ### Configuration

    📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

    ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

    🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

    ---

     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

    ---

    This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/gax-nodejs).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

commit 459573e3120ce74b069a7925b4484a4b947b492a
Merge: bfd5c1e 2fd932e
Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Date:   Mon Aug 21 22:30:55 2023 -0400

    Merge branch 'gax-4.0.3' into gax4upgrade-2

commit bfd5c1e30982738f41b949ad05783e7439db1539
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Thu Jul 27 15:24:01 2023 -0500

    chore(main): release 4.0.3 (#1482)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

commit 1a77db9183309bbf5fbc04a8de6a4938ccd1e6fc
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Thu Jul 27 15:05:21 2023 -0500

    fix: make gapic-tools depend on gax-nodejs (#1480)

    * fix: make gapic-tools depend on gax-nodejs

commit 39396f94dedbde287b2183bbcf91c185dbb0aa4d
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Tue Jul 25 17:46:33 2023 -0500

    chore(main): release 4.0.2 (#1479)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

commit 1ce3fbed477531b9a43ad199faa7c7b3a465ae74
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Tue Jul 25 17:30:18 2023 -0500

    fix: update some pnpm deps (#1478)

    * fix: update some pnpm deps

commit 39daee1b90d8228d413433d7226ae773893a2869
Author: Leah Cole <coleleah@google.com>
Date:   Mon Aug 21 15:42:05 2023 -0400

    fix ts error, branch is in sync with gax-4.0.1

commit 3067f89e33af4c8b19703439769de53c26f5d7ad
Author: Leah Cole <coleleah@google.com>
Date:   Mon Aug 21 15:15:12 2023 -0400

    make sequence service match #1001, fix tsconfig

commit 587629a7f5d8e22f1f5b941ca7c116daf2fe4abe
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Fri Jul 21 15:16:53 2023 -0700

    chore(main): release 4.0.1 (#1474)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

commit 359220a8941a6e8d22edbd830b98fb5f7a1cddf4
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Fri Jul 21 23:55:11 2023 +0200

    fix(deps): update dependency retry-request to v6 (#1477)

    Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

commit 894a1c84be07ab12ec0bb491731618fdabeec5f8
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Fri Jul 21 23:38:15 2023 +0200

    fix(deps): update dependency google-auth-library to v9 (#1476)

commit a7f5003addd18245f77c4a2a72b936c85de69695
Author: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Date:   Fri Jul 21 14:13:15 2023 -0700

    build: add extra test for Node 20, update windows tests (#1468)

    * build: add extra test for Node 20, update windows tests

    Source-Link: https://github.com/googleapis/synthtool/commit/38f5d4bfd5d51116a3cf7f260b8fe5d8a0046cfa
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:ef104a520c849ffde60495342ecf099dfb6256eab0fbd173228f447bc73d1aa9

    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

commit aad22248b24d6a7572948460d9e8241925bfb926
Author: Daniel Bankhead <danielbankhead@google.com>
Date:   Tue Jul 18 15:37:51 2023 -0700

    Fix: `rimraf` version + remove conflicting types (#1475)

    * Fix: `rimraf` version + remove conflicting types

    * chore: refactor `rimraf` import

    * chore: clean up

commit 07ef0602a521acf49ee76d6baba6b3dd00fc7a34
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Tue Jul 18 03:57:35 2023 +0200

    chore(deps): update dependency c8 to v8 (#1457)

commit e79cb287ae1ab3b33939ff85ec3f0255ac65be78
Author: Megan Potter <57276408+feywind@users.noreply.github.com>
Date:   Mon Jul 17 13:47:46 2023 -0400

    fix: the return types for IAM service methods should be arrays, to match ReturnTuple (#1001)

    * fix: the return types for IAM service methods should be arrays, to match ReturnTuple

    * fix: update PR to current types

    * fix: also fix explicit typings for IAM

    * build: work around circular dependency with kms (second PR to follow)

    * docs: broken tsdoc

commit 6eb75db56e2f0ab9c3176f8c28769ef71b8e931c
Author: Alexander Fenster <fenster@google.com>
Date:   Thu Jul 13 10:18:06 2023 -0700

    fix: replace proto-over-HTTP with REGAPIC (#1471)

commit d566e241cabd4bcc5154ed518e175e19d17fca50
Author: Alexander Fenster <fenster@google.com>
Date:   Thu Jul 13 10:00:57 2023 -0700

    test: run speech test from monorepo, use gapic-tools (#1472)

commit ebf8bf3b5dd25b2889904acc207e3a8f75586adc
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Thu Jul 13 00:06:38 2023 +0200

    chore(deps): update dependency protobufjs to v7.2.4 [security] (#1473)

    * chore(deps): update dependency protobufjs to v7.2.4 [security]

    * chore: update linkinator config

    ---------

    Co-authored-by: Alexander Fenster <fenster@google.com>

commit de661e5d3432303faa011bc26fd9db95ce8a781d
Author: Simen Bekkhus <sbekkhus91@gmail.com>
Date:   Wed Jul 12 23:20:05 2023 +0200

    fix(deps): update protobufjs (#1467)

    * fix: update protobufjs

    * chore: add exclusion to linkinator config

    ---------

    Co-authored-by: Alexander Fenster <fenster@google.com>

commit 9ee15450f6994090bab8786d7ece4a92c4d18029
Author: Alexander Fenster <fenster@google.com>
Date:   Tue Jul 11 15:34:54 2023 -0700

    fix: add missing devDependency for compodoc (#1470)

    * fix: add missing devDependency for compodoc

    * build: try with skipLibCheck

    * build: revert skipLibCheck

    * build: install dependency for compodoc

    * fix(deps): pin compodoc

commit c4031e60d1437754f57662d3ce6a9d354df08fab
Author: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Date:   Fri Jun 2 13:27:43 2023 -0700

    docs: update docs-devsite.sh to use latest node-js-rad version (#1454)

    Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

    Source-Link: https://github.com/googleapis/synthtool/commit/b1ced7db5adee08cfa91d6b138679fceff32c004
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:0527a86c10b67742c409dc726ba9a31ec4e69b0006e3d7a49b0e6686c59cdaa9

    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

commit 56171e69e91cb429c24ac77ad39451e97af338ec
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Wed May 17 12:24:54 2023 -0700

    chore(main): release 4.0.0 (#1445)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

commit 2c80abaff438e79b86e0779289e49b7c696a7d2c
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Wed May 17 11:59:43 2023 -0700

    build!: remove is-stream & fast-text-encoding dependencies (#1442)

commit 531e373019d8e87d061e5aee544ee5f92cdbd27f
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Wed May 17 11:45:53 2023 -0700

    feat!: drop Node 12 & decouple development dependencies (#1439)

    * feat!: get tools scripts and dependencies running; still need to get top-level module running without tools, remove extra dependencies, and make sure to run commands from the tools dependency

    * move to node 14
    ---------

    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

commit 6fa194518dd38ba8eb78cc6e7d99a3f8e9bf07e3
Author: Alexander Fenster <fenster@google.com>
Date:   Tue May 2 13:16:13 2023 -0700

    fix: compilation error in fallback.ts (#1444)

    The compilation failed for me on a clean install, possibly because of some auth library update. We don't really care about the real type of the returned auth client, so a simple type cast should be good.

commit fac92bcdb5882bd34e67e002c84d51f780f7034a
Author: Leah Cole <coleleah@google.com>
Date:   Mon Aug 21 11:48:37 2023 -0400

    Revert "fix: compilation error in fallback.ts (#1444)"

    This reverts commit 8e6888f469845a0a68dbab3047b3a6843e58da22.

commit 8b0de2398f196aef81f7d13861fb9d13d6bcb7e1
Author: Leah Cole <coleleah@google.com>
Date:   Mon Aug 21 11:48:18 2023 -0400

    Revert "feat!: drop Node 12 & decouple development dependencies (#1439)"

    This reverts commit 61a71436e9428c8118831a05fb5c7a3b2b3f99a5.

commit 31367d61ec90804d8a59f4174a3523ce10a535f3
Merge: ebc4eec 89ad507
Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Date:   Fri Aug 18 10:27:43 2023 -0400

    Merge pull request #7 from leahecole/remove-retryrequestoptions

    Add resumption tests, remove retryrequestoptions

commit 6d57b4b23d764e20a5f24d921ebc83624ebfbd11
Author: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Date:   Thu Aug 17 19:40:13 2023 +0000

    chore: update release-please post-processing for nodejs apiary (#1492)

    * fix: update release-please post-processing for nodejs apiary

    Source-Link: https://togithub.com/googleapis/synthtool/commit/59fe44fde9866a26e7ee4e4450fd79f67f8cf599
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:606f3d9d99a1c7cdfa7158cbb1a75bfeef490655e246a2052f9ee741740d736c

commit 89ad5078d666de075cefe2b06014cc5f4a2f22f5
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 17 14:49:18 2023 -0400

    cleanup

commit e8161433ed3a82d1eba487cd469c2e6102147f16
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 17 14:44:21 2023 -0400

    more cleanup

commit 55a02beee68cdcbda171aaec2eac2722b31341fa
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 17 14:30:02 2023 -0400

    cleanup comments

commit 4b4f87b6e17a9119fc6d1f964f473ca3364fb395
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 17 14:28:19 2023 -0400

    some cleanup

commit df98286f62365a6fa9bbb01989bee029718fe504
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 17 14:25:14 2023 -0400

    finish unit tests

commit 71a913b1093418029fd4b8d7d54cc5a200f99348
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 17 12:32:29 2023 -0400

    add one resumption unit test

commit 4748c9fc3a8cfe31e5abb3e35a6ee0d9a6f0e560
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Thu Aug 17 04:32:24 2023 +0200

    fix(deps): update dependency google-proto-files to v4 (#1490)

    Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

commit 5c7dfd021d1dc5d311e42d8c17b78fe616fed6fe
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Wed Aug 16 22:30:21 2023 +0200

    fix(deps): update dependency proto3-json-serializer to v2 (#1489)

commit 7a742ccaa5dbf3cf2dcb3e463cb3a67515590b01
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 16 16:14:35 2023 -0400

    remove retryrequestoptions from new retry logic

commit 561f6b93e12ae225c05ce744b9c64505cbf99ce3
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 16 15:50:35 2023 -0400

    make sure test-application passes

commit 28a77eef8092ff6e329cd732e46327b1cf71725f
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Wed Aug 16 12:43:54 2023 -0700

    build: update linter (#1491)

    * build: update linter

commit 8a63ed3ccfe76fab7567562d40da527c83f4d264
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 16 14:24:04 2023 -0400

    actually finish regen process

commit 7acf0058fd3306317b08c68db5226556987dc8ed
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 16 13:52:01 2023 -0400

    finish regen process

commit 03768de3479bb683160c54609971474f607d26c1
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 16 17:48:38 2023 +0000

    regen gapic showcase

commit 80f7747cebfcb241bd007e1b0cf50a899e8b0799
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 16 13:44:09 2023 -0400

    npm run fix

commit 8ae18ae6d0731b3d3d5ffb13872ba44a588f5919
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 16 13:05:00 2023 -0400

    move resumption to retryoptions

commit 702ec918b63b5946555a16f0093ec37de6089fa6
Author: Leah Cole <coleleah@google.com>
Date:   Fri Aug 11 14:24:09 2023 -0400

    fix lint

commit 34c1600e6b522a8ac935f4fcc864c084023c0dc8
Author: Leah Cole <coleleah@google.com>
Date:   Fri Aug 11 14:05:15 2023 -0400

    uncomment main test function

commit c2cba5b6802f180ab6bdfec030f94642c771bdf0
Author: Leah Cole <coleleah@google.com>
Date:   Fri Aug 11 14:04:51 2023 -0400

    remove debugging statements

commit 882969ac5b94d9349eeba19f4795bd7dbcbfe1cb
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 16:58:19 2023 -0400

    WIP: debugging

commit ce37b66bd426d906b4f240aa542a4f85c3efc63f
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 14:25:57 2023 -0400

    fix broken tests with regen client

commit b71edf7f18b15d6fcfa693c103259f0766736f55
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 14:20:47 2023 -0400

    manually add newRetry parameter

commit d61098a866095ef0287c8237dd844326d922b0df
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 18:05:07 2023 +0000

    update teh client again

commit 9be128482599c95e7e1027da4e1f38b52c120f89
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 13:49:42 2023 -0400

    remove unnecessary client files

commit 9699060103b948f91ad64667a204d259c94e1f97
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 17:42:58 2023 +0000

    regen clients again

commit 6f2f6767557b1197bf294bdc9bd88bc83f8851aa
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 12:41:54 2023 -0400

    WIP: print statements

commit 327a44c41a2c4113d481aec801538a5a1f2a4169
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 16:06:45 2023 -0400

    regenerate showcase

commit 04989edb41bdc189af0214b1a849ef3b6bb63d9b
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 19:47:32 2023 +0000

    try regenerating showcase

commit 1ee50c5db70ae99112d34d4b9b23efa5c4680e47
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 15:15:29 2023 -0400

    update showcase client

commit a17f048a20f0e25a5e20cca1a747b4da6275775e
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 19:12:25 2023 +0000

    add new showcase

commit ebc4eecfc0b6f17cdad8e24a439419e201ec7af3
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 10 12:04:13 2023 -0400

    add todo

commit d7e59675f4f688450e409e6964dfd5b841e58682
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 12:14:33 2023 -0400

    remove return statement

commit e77aee91464e518cc9c64a66ca23f49f8ab2a1f5
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 11:58:58 2023 -0400

    todos

commit 2e4ad05d430669277ba50f441e4fe41b0ebfc0d0
Merge: b9d57be 4f71c6b
Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Date:   Wed Aug 9 12:13:39 2023 -0400

    Merge pull request #5 from leahecole/docstrings

    resolve docstring todos

commit 4f71c6b02ab4f488b0e6108d0f9f88a33f719c2e
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 12:13:16 2023 -0400

    fix return type

commit cb1a33fdb5ae92e6bec07e449ce434e976eb47d4
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 9 12:05:50 2023 -0400

    remove retryStream after talking to gal

commit 9b41fc93d0ea276c691bcdb396a8bc4552921da4
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 8 16:01:53 2023 -0400

    resolve docstring todos

commit b9d57be194d4032103d512e3a3e6fccd643da0b5
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 8 14:48:46 2023 -0400

    npm run fix

commit ffb2943c9dce7f5fd19c209845b5af853c03f78c
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 8 14:47:22 2023 -0400

    merge

commit 383718fc1f1fdfb565b084c2c0e103a4f7707bf1
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu Aug 3 16:16:00 2023 -0700

    added unit tests and fixed unit test alignment

commit 8be2b65619c3ee64e23b0b77e27ae8b643c0168e
Merge: bf207a7 872ba3d
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu Aug 3 12:53:18 2023 -0700

    Merge branch 'gax-3.6.0-3' of https://github.com/leahecole/gax-nodejs into gax-3.6.0-3

commit bf207a713dd5cbe945c70caad0b66d41848159d4
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu Aug 3 12:52:55 2023 -0700

    added new test to test-application

commit 872ba3dda6e28e2d1d614057a25630fad688730b
Author: Leah Cole <coleleah@google.com>
Date:   Thu Aug 3 13:21:34 2023 -0400

    fix broken test

commit ea358ff7dc487295405b0f13c4722440910dfd09
Merge: efd41b1 ead6d35
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Aug 2 13:55:31 2023 -0700

    Merge branch 'gax-3.6.0-3' of https://github.com/leahecole/gax-nodejs into gax-3.6.0-3

commit ead6d356f1e72c5f51da0a71aea09ac0a9e2ed7e
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 2 16:54:57 2023 -0400

    fix failing test

commit efd41b1af404469fa23933a7d3092c49d5470fab
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Aug 2 13:54:44 2023 -0700

    Added test to test-application

commit debcdece9a9ea2e54327f4b43bbd102edf078fd6
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 2 16:04:41 2023 -0400

    address more todos

commit 6ef735bbeb39e059b0fe5fe43fb150e0ce16c656
Author: Leah Cole <coleleah@google.com>
Date:   Wed Aug 2 14:08:32 2023 -0400

    work on some todos

commit b3493c2a82ece0704493ee813513b5e90b248df2
Merge: 4d03684 55eb385
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Aug 2 10:36:22 2023 -0700

    Merge branch 'gax-3.6.0-3' of https://github.com/leahecole/gax-nodejs into gax-3.6.0-3

commit 4d03684db5ab18abd6d03148095ad0554336afe3
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Aug 2 10:35:36 2023 -0700

    wip commit

commit ea8020f9084ff068a3139a8b19be6b8c0caa74e3
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Wed Aug 2 13:20:13 2023 +0200

    fix(deps): update dependency @grpc/grpc-js to ~1.9.0 (#1486)

    [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

    This PR contains the following updates:

    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [@grpc/grpc-js](https://grpc.io/) ([source](https://togithub.com/grpc/grpc-node)) | [`~1.8.0` -> `~1.9.0`](https://renovatebot.com/diffs/npm/@grpc%2fgrpc-js/1.8.21/1.9.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@grpc%2fgrpc-js/1.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@grpc%2fgrpc-js/1.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@grpc%2fgrpc-js/1.8.21/1.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@grpc%2fgrpc-js/1.8.21/1.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

    ---

    ### Release Notes

    <details>
    <summary>grpc/grpc-node (@&#8203;grpc/grpc-js)</summary>

    ### [`v1.9.0`](https://togithub.com/grpc/grpc-node/releases/tag/%40grpc/grpc-js%401.9.0): @&#8203;grpc/grpc-js 1.9.0

    [Compare Source](https://togithub.com/grpc/grpc-node/compare/@grpc/grpc-js@1.8.21...@grpc/grpc-js@1.9.0)

    -   Implement channel idle timeout and the channel option `grpc.client_idle_timeout_ms` ([#&#8203;2471](https://togithub.com/grpc/grpc-node/issues/2471))
    -   Implement [gRFC A62: `pick_first`: sticky TRANSIENT_FAILURE and address order randomization](https://togithub.com/grpc/proposal/blob/master/A62-pick-first.md) ([#&#8203;2511](https://togithub.com/grpc/grpc-node/issues/2511))
    -   Fix premature leaving of context due to improper `Http2ServerCallStream` handling ([#&#8203;2501](https://togithub.com/grpc/grpc-node/issues/2501) contributed by [@&#8203;CedricKassen](https://togithub.com/CedricKassen))
    -   Add channel option `grpc-node.tls_enable_trace` to enable Node TLS tracing ([#&#8203;2507](https://togithub.com/grpc/grpc-node/issues/2507))
    -   Cancel deadline timer on server when call is cancelled ([#&#8203;2508](https://togithub.com/grpc/grpc-node/issues/2508))

    Experimental changes:

    -   Added `grpc.experimental.createResolver`

    </details>

    ---

    ### Configuration

    📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

    ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

    ---

     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

    ---

    This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/gax-nodejs).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

commit 55eb3856c01149af096a72bc3d0918002b72cfdb
Author: Leah Cole <coleleah@google.com>
Date:   Tue Aug 1 16:24:20 2023 -0400

    fix broken test

commit 75efdefc66adf4b0ed780d398750fa431afae479
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Mon Jul 31 15:53:47 2023 -0700

    added test and StreamingSequence factory

commit a6d92144d0cbc8fc3fa2cfc7cf8d66218cabb3a9
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jul 28 17:09:53 2023 -0700

    Fix all expected passing tests

commit b24269638f57eef8469610cf9f4eca2cda28dd61
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jul 28 17:00:23 2023 -0700

    remove one failing test, add a passing more relevant test

commit 2432c984b06e64f70f9c33d66a9f80e215775103
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jul 28 16:19:55 2023 -0700

    add afterEach for sinon.restore

commit c50286d0aac62144d025a6bf177db10e55856deb
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jul 28 16:18:43 2023 -0700

    make checkRetrySettings actually return something

commit 3d5b520abf44dd030165bbc0d8629d90aa1cb9d0
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jul 28 14:35:38 2023 -0700

    fix another test

commit 2e392a22c6c1bb09796f0e186275e53761af57b1
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jul 28 14:13:08 2023 -0700

    fix one test

commit 05917c71b48b7ee5a461dccd8e635190c755589b
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jul 28 14:10:53 2023 -0700

    fix one test

commit 8116222e050072eddefa18203bd8df3bd91faa03
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Fri Jul 28 13:25:19 2023 -0700

    removed unused variables

commit 9755031accf1c93b529b5f693b0e268f7a926fcd
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Fri Jul 28 13:13:27 2023 -0700

    wip commit

commit 2b2f84924b8dc723b913500e431631c4c55cf401
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Fri Jul 28 12:19:52 2023 -0700

    cleaned up streamHandoffHelper by adding helpers

commit a47c4fe34ab7c8c6f8204a6cec4b652c6bf86b63
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Thu Jul 27 22:50:13 2023 +0200

    chore(deps): update dependency @compodoc/compodoc to v1.1.21 (#1453)

    [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

    This PR contains the following updates:

    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [@compodoc/compodoc](https://togithub.com/compodoc/compodoc) | [`1.1.19` -> `1.1.21`](https://renovatebot.com/diffs/npm/@compodoc%2fcompodoc/1.1.19/1.1.21) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@compodoc%2fcompodoc/1.1.21?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@compodoc%2fcompodoc/1.1.21?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@compodoc%2fcompodoc/1.1.19/1.1.21?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@compodoc%2fcompodoc/1.1.19/1.1.21?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

    ---

    ### Release Notes

    <details>
    <summary>compodoc/compodoc (@&#8203;compodoc/compodoc)</summary>

    ### [`v1.1.21`](https://togithub.com/compodoc/compodoc/blob/HEAD/CHANGELOG.md#1121)

    [Compare Source](https://togithub.com/compodoc/compodoc/compare/1.1.20...1.1.21)

    ##### Bug fixes

    -   feat(app): downgrade Marked version ([e0a4b78](https://togithub.com/compodoc/compodoc/commit/e0a4b78)), closes [#&#8203;1349](https://togithub.com/compodoc/compodoc/issues/1349)

    ### [`v1.1.20`](https://togithub.com/compodoc/compodoc/blob/HEAD/CHANGELOG.md#1120---2023-05-23)

    [Compare Source](https://togithub.com/compodoc/compodoc/compare/1.1.19...1.1.20)

    ##### Merged

    -   fix(Input): Add support for Object Expressions in Input decorators [#&#8203;1326](https://togithub.com/compodoc/compodoc/pull/1326), Thanks [valentinpalkovic](https://togithub.com/valentinpalkovic)
    -   fix(app): overview depth [#&#8203;1310](https://togithub.com/compodoc/compodoc/pull/1310), Thanks [albeniraouf](https://togithub.com/albeniraouf)
    -   Translates to Bulgarian [#&#8203;1312](https://togithub.com/compodoc/compodoc/pull/1312), Thanks [3phase](https://togithub.com/3phase)

    ##### Bug fixes

    -   feat(app): Directive composition API for directives and components ([127076a](https://togithub.com/compodoc/compodoc/commit/127076a)), closes [#&#8203;1340](https://togithub.com/compodoc/compodoc/issues/1340)
    -   feat(app): Required Inputs ([e1a5396](https://togithub.com/compodoc/compodoc/commit/e1a5396)), closes [#&#8203;1340](https://togithub.com/compodoc/compodoc/issues/1340)
    -   feat(app): Standalone components, directives and pipes support ([cb02ca0](https://togithub.com/compodoc/compodoc/commit/cb02ca0)), closes [#&#8203;1323](https://togithub.com/compodoc/compodoc/issues/1323)
    -   fix(app): support exportAs for directives ([76a8f34](https://togithub.com/compodoc/compodoc/commit/76a8f34)), closes [#&#8203;1328](https://togithub.com/compodoc/compodoc/issues/1328)
    -   feat(app): bump [@&#8203;compodoc/ngd-transformer](https://togithub.com/compodoc/ngd-transformer) ([ef9bd94](https://togithub.com/compodoc/compodoc/commit/ef9bd94)), closes [#&#8203;1311](https://togithub.com/compodoc/compodoc/issues/1311)
    -   fix(app): service/injectable export in module providers ([34967a9](https://togithub.com/compodoc/compodoc/commit/34967a9)), closes [#&#8203;1290](https://togithub.com/compodoc/compodoc/issues/1290)
    -   fix(app): missing rel attribute with \_blank links ([c8379e0](https://togithub.com/compodoc/compodoc/commit/c8379e0)), closes [#&#8203;1282](https://togithub.com/compodoc/compodoc/issues/1282)
    -   feat(app): Add specific id in each html section ([03ac1ad](https://togithub.com/compodoc/compodoc/commit/03ac1ad)), closes [#&#8203;1241](https://togithub.com/compodoc/compodoc/issues/1241)
    -   fix(app): Invalid links to a class when the class name includes an interface name ([047cedb](https://togithub.com/compodoc/compodoc/commit/047cedb)), closes [#&#8203;1239](https://togithub.com/compodoc/compodoc/issues/1239)
    -   fix(routing): path wrongly resolved during routing analysis ([1722ca3](https://togithub.com/compodoc/compodoc/commit/1722ca3)), closes [#&#8203;1170](https://togithub.com/compodoc/compodoc/issues/1170)

    </details>

    ---

    ### Configuration

    📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

    ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

    ---

     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

    ---

    This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/gax-nodejs).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

commit e4f548254bfce3daa3b02ae81764bb3394fc4f23
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Thu Jul 27 15:35:40 2023 -0500

    fix: release new version of gapic-tools (#1483)

    Need to do this until I set up the release-please process properly.

commit 73fcc79413d7ec041d0be06c95a47ea0141c391c
Merge: 4450439 b7db054
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu Jul 27 13:33:39 2023 -0700

    Merge branch 'gax-3.6.0-3' of https://github.com/leahecole/gax-nodejs into gax-3.6.0-3

commit 44504395f47cb094411e21f7d4071970f3fb231f
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu Jul 27 13:32:12 2023 -0700

    refactored to use retry.retryCodesOrShouldRetryFn

commit 2fd932e96255f7ece901b2c3e1b08873632a0836
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Thu Jul 27 15:24:01 2023 -0500

    chore(main): release 4.0.3 (#1482)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

commit d0f410d2e08f393f2661c8c92568a0b518fddf99
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Thu Jul 27 15:05:21 2023 -0500

    fix: make gapic-tools depend on gax-nodejs (#1480)

    * fix: make gapic-tools depend on gax-nodejs

commit b7db0545983f0384edc51c62d6311b8aca520006
Author: Leah Cole <coleleah@google.com>
Date:   Thu Jul 27 15:48:36 2023 -0400

    fix one instance of shoudlretryfn

commit 0bbce136021a3c88108f4317323d0869b959250c
Merge: 5062a61 bda9605
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu Jul 27 12:27:23 2023 -0700

    Merge pull request #4 from leahecole/b/279946426

    B/279946426

commit bda9605b9ea6ac897fc20919e3dd58b8e779a74c
Merge: 4dab819 5062a61
Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Date:   Thu Jul 27 22:05:59 2023 +0300

    Merge branch 'gax-3.6.0-3' into b/279946426

commit 4dab819d44c466bf4fd23ceeaaa721f789ac4227
Author: Leah Cole <coleleah@google.com>
Date:   Thu Jul 27 14:41:55 2023 -0400

    remove typo

commit 5062a616f98c0b70827d2c94197033c29a2c0b52
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu Jul 27 10:44:34 2023 -0700

    uncommit streaming unit tests

commit 7eba460024e498eaa91f1427c7d44bacf2b49b61
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Jul 26 15:51:48 2023 -0700

    Added getResumptionRequestFn

commit 561cec4e111f2c79815a602a69c8e330b1508521
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Jul 26 13:31:35 2023 -0700

    WIP Commit: Added shouldRetryFn and fixed tests

commit 0b6784f596dfa9786a214143eef6bdda20bfa570
Author: Leah Cole <coleleah@google.com>
Date:   Wed Jul 26 15:38:08 2023 -0400

    a few more assertions

commit 30193ad2f41c4e29a3292eb4ef517d9e19791b54
Author: Leah Cole <coleleah@google.com>
Date:   Wed Jul 26 13:37:06 2023 -0400

    fix lint, add todos

commit 2bb9ae256af30ce27837c71b34da0705604186a3
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Tue Jul 25 17:46:33 2023 -0500

    chore(main): release 4.0.2 (#1479)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

commit 39583d5f4faab89b511fe317bd1ec3334c2ea3f5
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date:   Tue Jul 25 17:30:18 2023 -0500

    fix: update some pnpm deps (#1478)

    * fix: update some pnpm deps

commit 6927a11d6748ea35b8437a9482b1f3c20bd916e1
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Tue Jul 25 15:26:46 2023 -0700

    WIP Commit

commit bf39468b65c7e13f2efe50b57396911c7a3becd7
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Tue Jul 25 11:33:00 2023 -0700

    WIP commit

commit e791c79947f227e90bbd54dda644e6805948f785
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Mon Jul 24 10:51:59 2023 -0700

    fixed failing unit test

commit 8663eb14f9c6c6ab3a6009f6725b347698f6e1f3
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Fri Jul 21 15:16:53 2023 -0700

    chore(main): release 4.0.1 (#1474)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

commit 6401a88c50fa0eb3eb8a73cefc830896369c3330
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Fri Jul 21 23:55:11 2023 +0200

    fix(deps): update dependency retry-request to v6 (#1477)

    Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

commit 8afdd591646a190fde38728f0df14c604643f5cc
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Fri Jul 21 23:38:15 2023 +0200

    fix(deps): update dependency google-auth-library to v9 (#1476)

commit 9e93eddc27fbb140a2bdaaef2e9d0db3a05921f4
Author: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Date:   Fri Jul 21 14:13:15 2023 -0700

    build: add extra test for Node 20, update windows tests (#1468)

    * build: add extra test for Node 20, update windows tests

    Source-Link: https://github.com/googleapis/synthtool/commit/38f5d4bfd5d51116a3cf7f260b8fe5d8a0046cfa
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:ef104a520c849ffde60495342ecf099dfb6256eab0fbd173228f447bc73d1aa9

    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

commit 0252683e00ab3486efb1d606996c2b9bf0c6e085
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Fri Jul 21 13:15:50 2023 -0700

    changed name of forwardClientEvents

commit f5f27a8a51feabecc90b854860fa5266c18cf7b2
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Fri Jul 21 13:03:48 2023 -0700

    lint changes

commit 6631734a51fb4bc270c7012d03af1f3c6eba62ec
Author: Leah Cole <coleleah@google.com>
Date:   Thu Jul 20 16:12:27 2023 -0400

    reorganize streaming unit tests

commit e4daff99df9ad612b4713d3b467713e394339e73
Author: Leah Cole <coleleah@google.com>
Date:   Thu Jul 20 15:51:07 2023 -0400

    convert retryCodes to retryCodesorShouldRetryFn

commit f9f8b1328c38718bf621b92338b3d81297525aa6
Author: Daniel Bankhead <danielbankhead@google.com>
Date:   Tue Jul 18 15:37:51 2023 -0700

    Fix: `rimraf` version + remove conflicting types (#1475)

    * Fix: `rimraf` version + remove conflicting types

    * chore: refactor `rimraf` import

    * chore: clean up

commit f4a46be2b6a1e2771085ca86f5ce64a1fbdb3c1a
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Tue Jul 18 03:57:35 2023 +0200

    chore(deps): update dependency c8 to v8 (#1457)

commit 2f71435ef3fb8c9d14d00acf172ff1e4b36b82a7
Author: Leah Cole <coleleah@google.com>
Date:   Mon Jul 17 16:01:31 2023 -0400

    finish rebasing Gal's work into mine

commit 4fe5f2d5c677ed02e9876e7b8b818ac067aac674
Author: Leah Cole <coleleah@google.com>
Date:   Mon Jul 17 15:41:58 2023 -0400

    uncomment for rebase

commit 8709ac9e84a76d2c1bdac8af476e0f8e977471e0
Author: Leah Cole <coleleah@google.com>
Date:   Mon Jul 17 15:40:15 2023 -0400

    uncomment tests for rebase

commit 866fd2aaa03d445c4ca393f8abcfa4f03dcd3f6e
Author: Leah Cole <coleleah@google.com>
Date:   Mon Jul 17 15:28:32 2023 -0400

    WIP: param conversion

commit 4a67dd412083e632b24c3136f850a417741bf98f
Author: Leah Cole <coleleah@google.com>
Date:   Thu Jul 13 15:56:02 2023 -0400

    WIP: test and parameter conversion

commit 786b7be8b7f850d46547a3240b6cc81954a9459e
Author: Leah Cole <coleleah@google.com>
Date:   Thu Jul 13 15:55:32 2023 -0400

    fix: update retryrequestoptions to be aligned with retry-request

commit 0a671ea24fb0a0c11aaaea507e0dab4d44a06c5e
Author: Leah Cole <coleleah@google.com>
Date:   Tue Jun 27 15:18:26 2023 -0400

    passing tests for warnings

commit 385b7861d3a335840c7894dc5e22f07e4ac355a1
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jun 23 14:25:55 2023 -0400

    WIP: adding more unit tests

commit 820ed4ff340ac3e06d48e57ada33a8826e66ea8b
Author: Leah Cole <coleleah@google.com>
Date:   Wed Jun 21 15:41:41 2023 -0400

    add test for both parameters being set

commit 3ffc9684c4d21d309b97df6c2d0ed1d9548953a3
Author: Leah Cole <coleleah@google.com>
Date:   Fri Jun 16 15:11:51 2023 -0400

    WIP: experimenting with spies in streaming calls

commit 8a05223c68507cc0b10b455a0cd377dd8a96eaf7
Author: Leah Cole <coleleah@google.com>
Date:   Tue Jun 13 16:48:28 2023 -0400

    WIP: adding unit tests for option conversion

commit 48eed955e7329f55f9427a7bc0656cfe2af395e8
Author: Megan Potter <57276408+feywind@users.noreply.github.com>
Date:   Mon Jul 17 13:47:46 2023 -0400

    fix: the return types for IAM service methods should be arrays, to match ReturnTuple (#1001)

    * fix: the return types for IAM service methods should be arrays, to match ReturnTuple

    * fix: update PR to current types

    * fix: also fix explicit typings for IAM

    * build: work around circular dependency with kms (second PR to follow)

    * docs: broken tsdoc

commit 4266f43922d0d582b8eced11f4a21c98a8b451fe
Author: Alexander Fenster <fenster@google.com>
Date:   Thu Jul 13 10:18:06 2023 -0700

    fix: replace proto-over-HTTP with REGAPIC (#1471)

commit c1c4dc19da45780ade32178f9f7ac76e8bb5aef1
Author: Alexander Fenster <fenster@google.com>
Date:   Thu Jul 13 10:00:57 2023 -0700

    test: run speech test from monorepo, use gapic-tools (#1472)

commit 7b8414bbb0c535e23dac90e8461a8145d6b6d08d
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Jul 12 15:44:36 2023 -0700

    added tests

commit d2a5ccbf93a987bc4ae6fd6bc3e319ddf10d26f6
Author: Mend Renovate <renovate@whitesourcesoftware.com>
Date:   Thu Jul 13 00:06:38 2023 +0200

    chore(deps): update dependency protobufjs to v7.2.4 [security] (#1473)

    * chore(deps): update dependency protobufjs to v7.2.4 [security]

    * chore: update linkinator config

    ---------

    Co-authored-by: Alexander Fenster <fenster@google.com>

commit 0a7dd948573bd9553a0e9548e9ab92dbcfcb7414
Author: Simen Bekkhus <sbekkhus91@gmail.com>
Date:   Wed Jul 12 23:20:05 2023 +0200

    fix(deps): update protobufjs (#1467)

    * fix: update protobufjs

    * chore: add exclusion to linkinator config

    ---------

    Co-authored-by: Alexander Fenster <fenster@google.com>

commit 170a5b69a8d4610fb95ad149ba3632904286a904
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Jul 12 11:17:25 2023 -0700

    uncomment tests and remove streaming retries.ts

commit 6fd1c08de3375df460507ce0ea0d588fb9bd1d65
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Jul 12 10:49:40 2023 -0700

    added check in forwardEvents for API retry

commit f551ba8ca5d573a245830916f93fa65cfd44df67
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Jul 12 10:30:31 2023 -0700

    add checks to forwardClientEvents

commit 115e317728c8ae6fa0e61f54d0087e26382d8230
Author: Alexander Fenster <fenster@google.com>
Date:   Tue Jul 11 15:34:54 2023 -0700

    fix: add missing devDependency for compodoc (#1470)

    * fix: add missing devDependency for compodoc

    * build: try with skipLibCheck

    * build: revert skipLibCheck

    * build: install dependency for compodoc

    * fix(deps): pin compodoc

commit f420a787774464130caa27724d04ba339b796110
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Mon Jul 10 15:44:53 2023 -0700

    added check to see which retryCodes are allowed

commit c628a344404ec68ded19dfa67f0be73d562c139e
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Fri Jul 7 11:24:40 2023 -0700

    server stream update

commit 17621154683532383505d8d07e8f82fdc4aad8ac
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Mon Jun 26 14:01:08 2023 -0700

    added retry logic

commit c51b69b14808717a295851af2b263289dc35f5cc
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Wed Jun 14 11:06:09 2023 -0700

    updated retry logic

commit 1ac4135dc151adec5d744d1ce5a60202b221a299
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Tue Jun 13 13:04:37 2023 -0700

    added retry logic

commit 6e7135f53e83e799d0b57ee5eb08e0d609dea165
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Mon Jun 5 15:23:23 2023 -0700

    added changes

commit 82aaa3996514aa74cd7078da095d7509fc91cf3d
Author: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Date:   Fri Jun 2 13:27:43 2023 -0700

    docs: update docs-devsite.sh to use latest node-js-rad version (#1454)

    Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

    Source-Link: https://github.com/googleapis/synthtool/commit/b1ced7db5adee08cfa91d6b138679fceff32c004
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:0527a86c10b67742c409dc726ba9a31ec4e69b0006e3d7a49b0e6686c59cdaa9

    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

commit 1473e5a8c7c5c3f5b068462fbaf275077216ae34
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Tue May 30 14:11:16 2023 -0700

    changed StreamRetries to StreamRetryRequest

commit 5d4e24206b720a07995227011ffe5d5940c3fe4e
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Thu May 25 13:47:32 2023 -0700

    Added new streamingRetryRequest option

commit b7b416cec3a3abd98bc4304eb7264f6963daaf1b
Author: Leah Cole <coleleah@google.com>
Date:   Wed May 24 18:04:23 2023 -0400

    add one dev dependency

commit b2769be042ea4b872483dc1bca270d648b6efb6b
Author: Leah Cole <coleleah@google.com>
Date:   Wed May 24 17:51:41 2023 -0400

    Revert "feat!: drop Node 12 & decouple development dependencies (#1439)"

    This reverts commit 61a71436e9428c8118831a05fb5c7a3b2b3f99a5.

commit 10b92429add5eaa05a548da9d1cfa396defb1618
Author: Leah Cole <coleleah@google.com>
Date:   Wed May 24 17:49:03 2023 -0400

    Revert "build!: remove is-stream & fast-text-encoding dependencies (#1442)"

    This reverts commit 111133c5a2bd5a54ebe99a337de9a5a58ee67d2e.

commit 1489e3711b9362c6c2d4e91e5bf6d10db34397f3
Author: Leah Cole <coleleah@google.com>
Date:   Wed May 24 17:49:01 2023 -0400

    Revert "chore(main): release 4.0.0 (#1445)"

    This reverts commit 064e131ba7371e6d994e3d73790fa5e1fd09189a.

commit e445d8ff207539bf4fef4595f69497cac9240083
Author: Leah Cole <coleleah@google.com>
Date:   Tue May 2 16:06:55 2023 -0400

    revert our changes to how the server runs

commit 3806b29afef55b9639a1e54da7006aaa92bd1dd8
Author: Leah Cole <coleleah@google.com>
Date:   Tue May 2 15:27:22 2023 -0400

    replace status codes with enums

commit a56867d5a56da088da0c846174a35944ca74eed2
Author: Leah Cole <coleleah@google.com>
Date:   Tue May 2 14:58:32 2023 -0400

    remove not needed things

commit 8a4806c4f679206c8f31e03be0b5fd42a17d41c9
Author: Leah Cole <coleleah@google.com>
Date:   Tue May 2 14:31:55 2023 -0400

    revert copyright year

commit b430bb2ebc4e0ed8cd8e84d27b75bb37213d027b
Author: Leah Cole <coleleah@google.com>
Date:   Tue May 2 14:27:36 2023 -0400

    pacakge.json change

commit ad7cb0c10828b710996b9f54fdaeba0ca44961d6
Author: Leah Cole <coleleah@google.com>
Date:   Tue May 2 14:26:38 2023 -0400

    revert package.json changes

commit a6df06029d8c0d0679f3a2f0c0e56f1ec1003ce8
Author: Cloud Composer Team <no-reply@google.com>
Date:   Tue May 2 17:47:21 2023 +0000

    run npm run fix on the showcase client

commit 8cac3da20b6c58d35ceecc73ecb7142998102a0b
Author: Cloud Composer Team <no-reply@google.com>
Date:   Wed Apr 26 19:44:49 2023 +0000

    update showcase-echo-client

commit 17b32ca0ccc4c2103688abccc85fc2095d3f19a4
Author: Leah Cole <coleleah@google.com>
Date:   Tue Apr 25 14:14:18 2023 -0400

    Add comment to alex`

commit 6ae2f431ceb04efa25ffd6def7cc19f573e6e0bf
Author: Leah Cole <coleleah@google.com>
Date:   Tue Apr 25 13:32:23 2023 -0400

    add back imports for running w/ local showcase-server

commit 1c64a2330082baf9ba610a81cb94ec89d9180baa
Author: Leah Cole <coleleah@google.com>
Date:   Tue Apr 25 13:30:49 2023 -0400

    add first couple of tests for sequence streaming

commit 2022441d1bae0a22fc8e6e9475d531a9a0310c2d
Author: Leah Cole <coleleah@google.com>
Date:   Tue Apr 25 11:09:31 2023 -0400

    WIP: Getting tests ready for PR

commit 11df39223f15a6b1a3b588ca6bc9bd43304e2183
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Mon Apr 24 21:28:44 2023 +0300

    updated streamingNotRetryEligible

commit 0671a2f5ad8e25bed27e5ea5efd12d420f73dd01
Author: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Date:   Fri Apr 21 22:00:44 2023 +0300

    WIP: edit streamingNotRetryEligible test

    Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com>

commit ed0918da295a8d92f4bfcfe6ef9bc8fb632d830f
Author: Leah Cole <coleleah@google.com>
Date:   Wed Apr 19 16:20:14 2023 -0400

    WIP: test for non retry eligible calls

commit 3bea8a058365137d093cafc7983c791fc64e7f96
Author: Leah Cole <coleleah@google.com>
Date:   Wed Apr 19 15:37:17 2023 -0400

    fix broken tests, add comments with next steps

commit b2c5afd750ba1c255382bd2d8a0ce1e71f3e28d2
Author: Leah Cole <coleleah@google.com>
Date:   Tue Apr 18 13:54:54 2023 -0400

    fix merge conflict

commit 8be6b90c01bd81dd0db448d4c2e28a201c820eb7
Author: Gal Zahavi <galzahavi@google.com>
Date:   Tue Apr 18 17:41:59 2023 +0000

    chore : added sequenceStreamingService

* rerun npx gts fix

* fix two of three failing browser tests

* Regenerate showcase (#12)

* regenerate client

* npx gts fix

* add new retry

* remove tsconfig changes

* fix lint

* test: use a custom header for testing headers

* rename "newRetry" parameter

* remove extend dependency

* fix lint

* fix issue where underlying errors were swallowed

* resolve some comments

* replace console logs with our warn module

* utilize enum

* replace "any" with "GoogleError"

* update array checks

* remove debug statement

* remove need to typecast

* null coalescing fix

* reduce duplication

* clean up some optional chaining

* make error optional

* WIP: use nullish coalescing and optional chaining for parameter converesion

* more nullish coalescing and optional chaining

* falsiness checks

* Request/response type

lint

* Request/response type

lint

fix failing test

* make createAPIcall nested statements more readable

* retryCodesOrShouldRetryFn

* make retryCodesOrShouldRetryFn less awful

* fix Sofia's comments

* Retrycodes refactor (#13)

* WIP - accidentally tests transient error

* WIP - updating parameter, adding tests

* update retrycodes

* update unit tests

* remove redundant parameter check

* remove unused check

* uncomment necessary return

* add second transient check

* WIP: more unit tests

* remove unneeded function from streaming test

* remove debug statements

* npm run fix

* address feedback, remove unused parts of streamingRetryRequest

* remove unused streamingRetryRequestCode

* resolve typescript warnings

* fix: dont retry on empty retryCodes server stream

* npm run fix

---------

Co-authored-by: Alexander Fenster <fenster@google.com>
  • Loading branch information
@leahecole @alexander-fenster
leahecole and alexander-fenster authored Mar 28, 2024
1 parent 8dcb429 commit 150a683
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 2 deletions.
5 changes: 3 additions & 2 deletions gax/src/streamingCalls/streaming.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,9 @@ export class StreamProxy extends duplexify implements GRPCCallResult {

defaultShouldRetry(error: GoogleError, retry: RetryOptions) {
if (
retry.retryCodes.length > 0 &&
retry.retryCodes.indexOf(error!.code!) < 0
(retry.retryCodes.length > 0 &&
retry.retryCodes.indexOf(error!.code!) < 0) ||
retry.retryCodes.length === 0
) {
return false;
}
Expand Down
54 changes: 54 additions & 0 deletions gax/test/unit/streaming.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1265,6 +1265,60 @@ describe('handles server streaming retries in gax when gaxStreamingRetries is en
}
});
});
it('does not retry when there is no shouldRetryFn and retryCodes is an empty array', done => {
const retrySpy = sinon.spy(streaming.StreamProxy.prototype, 'retry');
const firstError = Object.assign(new GoogleError('UNAVAILABLE'), {
code: 14,
details: 'UNAVAILABLE',
metadata: new Metadata(),
});

const spy = sinon.spy((...args: Array<{}>) => {
assert.strictEqual(args.length, 3);
const s = new PassThrough({
objectMode: true,
});
s.push('hello');
setImmediate(() => {
s.emit('metadata');
});
setImmediate(() => {
s.emit('error', firstError);
});
return s;
});

const apiCall = createApiCallStreaming(
spy,
streaming.StreamType.SERVER_STREAMING,
false,
true
);

const call = apiCall(
{},
{
// pass an empty array for retryCodes
retry: gax.createRetryOptions([], {
initialRetryDelayMillis: 100,
retryDelayMultiplier: 1.2,
maxRetryDelayMillis: 1000,
rpcTimeoutMultiplier: 1.5,
maxRpcTimeoutMillis: 3000,
maxRetries: 2,
}),
}
);

call.on('error', err => {
assert(err instanceof GoogleError);
if (err.code === 14) {
assert.strictEqual(err.code, 14);
assert.strictEqual(retrySpy.callCount, 0);
done();
}
});
});

it('server streaming call retries until exceeding total timeout', done => {
const firstError = Object.assign(new GoogleError('UNAVAILABLE'), {
Expand Down

0 comments on commit 150a683

Please sign in to comment.