Skip to content

Commit

Permalink
chore!: migrate gax to Node 18 (#1699)
Browse files Browse the repository at this point in the history
* chore!: migrate gax to Node 18

* cleanup

* chore: upgrade to node 18

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* migrate to node 18

* downgrade dep

* update package.json

* downgrade dep

* chore: update to node-feth v3 and fix typings issues

* downgrade execa

* try to make node-fetch v3 work

* update node version

* update regapic

* chore: update regapic imports

* reconfigure mocking

* chore: use node-fetch v3

* Update CODEOWNERS

* Update release-trigger.yml

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* attempt to get browser tests working

* add json file to tsconfig

* retry

* retry

* retry

* retry

* more ts changes

* retry

* retry

* retry loading node fetch

* reattempt to lalow dynamic import

* revert node-fetch

* readd json files

* readd json files

* downgrade types/node

* retry

* retry browser test

* PR cleanup;

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update .OwlBot.lock.yaml

* Update .OwlBot.lock.yaml

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert change to tsconfig

* remove node 12 configs

* fix: upgrade webpack to v5 to match the new typescript version

* run lint

* attempt to fix linting problem

* remove floating promises TS error for tests

* add @ sign to disable linting

* chore: migrate tools to node 18 as well

* downgrade walkup

* run lint

* fix lint

* attempt to upgrade node-fetch to v3

* run lint

* readd abort controller

* readd abort controller in test

* run lint

* run lint

* fix tests

* fix tests

* run lint

* upgradependencies

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: d-goog <188102366+d-goog@users.noreply.github.com>
  • Loading branch information
3 people authored Feb 19, 2025
1 parent 27c52a0 commit fc3eeaa
Show file tree
Hide file tree
Showing 104 changed files with 1,842 additions and 1,863 deletions.
4 changes: 2 additions & 2 deletions .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ branchProtectionRules:
- docs
- lint-gax
- lint-tools
- test-gax (14)
- test-gax (18)
- test-gax (16)
- test-tools (14)
- test-tools (18)
- test-tools (16)
- cla/google
- windows-gax
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -30,7 +30,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 16]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -51,7 +51,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -72,7 +72,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -95,7 +95,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd gax; npm install
- run: cd gax; npm test
env:
Expand All @@ -106,7 +106,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd tools; npm install
- run: cd tools; npm test
env:
Expand All @@ -117,7 +117,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd logging-utils; npm install
- run: cd logging-utils; npm test
env:
Expand All @@ -128,7 +128,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd gax; npm install
- run: cd gax; npm run lint
lint-tools:
Expand All @@ -137,7 +137,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd tools; npm install
- run: cd tools; npm run lint
lint-logging-utils:
Expand All @@ -146,7 +146,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd logging-utils; npm install
- run: cd logging-utils; npm run lint
docs:
Expand All @@ -155,7 +155,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd gax; npm install
- run: cd gax; npm run docs
- uses: JustinBeckwith/linkinator-action@v1
Expand Down
2 changes: 1 addition & 1 deletion .kokoro/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 0 additions & 24 deletions .kokoro/continuous/node14/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node14/lint.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/system-test.cfg

This file was deleted.

Empty file removed .kokoro/continuous/node14/test.cfg
Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node14/common.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/system-test.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node14/test.cfg
Empty file.
2 changes: 1 addition & 1 deletion .kokoro/release/docs.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/release/publish.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/samples-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions gax/.eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ build/
docs/
protos/
samples/generated/
test/browser-test/
test/showcase-echo-client/src/
test/showcase-server/
test/test-application/src/
Loading

0 comments on commit fc3eeaa

Please sign in to comment.