fix: edit timeout and retry logic #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
alicejli
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| retry !== null && | ||
| retry.retryCodes.length > 0 | ||
| ) { | ||
| retry.backoffSettings.initialRpcTimeoutMillis = timeout; |
There was a problem hiding this comment.
Thank you confirm from the design doc. If a user provide timeout and retry.backoffSetting, we are repect the retry setting.
summer-ji-eng
approved these changes
Sep 15, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 15, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.25.4](https://www.github.com/googleapis/gax-nodejs/compare/v2.25.3...v2.25.4) (2021-09-15) ### Bug Fixes * editing retry logic ([#1100](https://www.github.com/googleapis/gax-nodejs/issues/1100)) ([05548d5](https://www.github.com/googleapis/gax-nodejs/commit/05548d5ba287af5a8833402108ac55d900889a38)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
feywind
added a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 18, 2021
feywind
added a commit
to googleapis/nodejs-pubsub
that referenced
this pull request
Nov 18, 2021
summer-ji-eng
pushed a commit
to stephenplusplus/gax-nodejs
that referenced
this pull request
Jan 5, 2022
…is#1024) * build: add auto-approve to Node libraries Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Link: googleapis/synthtool@5cae043 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:65aa68f2242c172345d7c1e780bced839bfdc344955d6aa460aa63b4481d93e5
This was referenced Jan 16, 2022
This was referenced Sep 10, 2024
This was referenced Sep 17, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates gax retry/timeout logic such that:
a) If a service defines a method-specific timeout_millis in their service_grpc_config.json file, that value will override and be used as the totalTimeoutMillis, initialRpcTimeoutMillis, and maxRpcTimeoutMillis value. This is similar to how Java/PHP microgenerators handle timeouts.
b) If a user defines a timeout value, then that value will override and be used as the totalTimeoutMillis, initialRpcTimeoutMillis, and maxRpcTimeoutMillis value (note that a user-defined timeout will supercede a service-defined timeout).
Fixes #902
Fixes #1013