Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps)!: update proto-loader to 0.6.11 #1245

Closed
wants to merge 6 commits into from
Closed

chore(deps)!: update proto-loader to 0.6.11 #1245

wants to merge 6 commits into from

Conversation

summer-ji-eng
Copy link
Contributor

gax generated code in /protos import long. With upgrade tolong v5, it cause compiling error similar in grpc/grpc-node#2111.

Thanks to @murgatroid99 fixed in grpc/grpc-node#2112.

Now library could compile with version 0.6.11

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner May 3, 2022 23:01
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 3, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 4, 2022
@summer-ji-eng summer-ji-eng mentioned this pull request May 4, 2022
Closed
4 tasks
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels May 4, 2022
@summer-ji-eng summer-ji-eng mentioned this pull request May 4, 2022
Merged
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 4, 2022
bcoe
bcoe suggested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this a breaking change, so that we explicitly need to update client libraries to the new version of gax to pull in 0.6.11 of @grpc/proto-loader.

Then we can perform a mass update that updates the gax version and also adds the long dependency.

@summer-ji-eng summer-ji-eng changed the title chore(deps): update proto-loader to 0.6.11 chore(deps)!: update proto-loader to 0.6.11 May 4, 2022
@sofisl sofisl mentioned this pull request May 4, 2022
Closed
1 task
@summer-ji-eng
Copy link
Contributor Author

#1253 should fix the issue. Close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe requested changes

@losalex losalex losalex approved these changes

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@summer-ji-eng @bcoe @losalex