Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove pageSize/pageToken from call settings #1263

Merged
merged 3 commits into from
May 9, 2022
Merged

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented May 9, 2022

There are two API-level options that exist on the CallOptions object. This means users call (through a client library):

// spanner.getInstances(apiOptions, [gaxOptions], callback)

// Expected usage:
spanner.getInstances({ filter: '...', pageSize: 10 }, { autoPaginate: true }, (err, results) => {})

// Possible usage that is weird:                                                ↓ two pageSizes!
spanner.getInstances({ filter: '...', pageSize: 10 }, { autoPaginate: true, pageSize: 11 }, (err, results) => {})

This PR removes those options from the CallOptions object, which (hopefully) isn't deadly in terms of actual functionality.

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner May 9, 2022 21:23
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 9, 2022
@summer-ji-eng
Copy link
Contributor Author

summer-ji-eng commented May 9, 2022

accidentally closed #821

Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it, finally :)

@summer-ji-eng summer-ji-eng merged commit fbf43d2 into main May 9, 2022
@summer-ji-eng summer-ji-eng deleted the pr/821 branch May 9, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants