fix: protobufjs-compatible camel case #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
approved these changes
Jul 1, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [3.1.3](v3.1.2...v3.1.3) (2022-07-01) ### Bug Fixes * protobufjs-compatible camel case ([#1286](#1286)) ([c751200](c751200)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings camel case implementation in gax on the same page with the implementation in gapic-generator-typescript and in protobuf.js. The only affected use cases are strings that have multiple capital letters, e.g.
GetOSPolicySomething, which protobuf.js wants to see asgetOsPolicySomething; I believe these names do not work now, so this is a fix rather than a breaking change in behavior.Tested locally that OSConfig API works with this change (and the generator change in googleapis/gapic-generator-typescript#1157).
I removed some unit tests that did not make sense (contained characters that never occur in names but prevented this refactor).