internal: add go.mod and go.sum file

[jeanbza]

This commit was generated by go mod init && go mod tidy

[enocom]

LGTM. I'd appreciate a second pair of eyes from either @jba or @pongad.

[broady]

CL description: "internal" doesn't sound right. maybe "all" or just no prefix?

[pongad]

I think this will cause circular imports? Do we need to split the cloud repo first...?

[jba]

Why does genproto need cloud.google.com/go?

[jeanbza]

Yikes. Yeah. I'll go make the relevant mod files. The path is:

genproto -> grpc -> oauth2 -> cloud.google.com/go/compute/metadata

[jeanbza]

I've come to the conclusion that this cyclic dependency must be allowed if we want to add a go.mod file in the near future:

• Cyclic module dependencies are OK [1]. Cyclic package dependencies are not OK and enforced by the compiler.
• x/oauth2/google must get a mod file that specifically requires cloud.google.com/go/compute/metadata instead of cloud.google.com/go to resolve this circular dependency.
• x/ repos are quite a ways out from getting modules [2] [3].

We could wait for the x/ changes, but I think given the first point it's OK to go ahead now. WDYT?

1: https://groups.google.com/forum/#!searchin/golang-nuts/import$20cycle%7Csort:date/golang-nuts/h2r8ktgOOZI/Pm6uyj5BCQAJ
2: golang/go#28136
3: golang/go#27858

[pongad]

This is slightly unfortunate but sounds fine with me.

[jba]

Oh, that damn compute/metadata. That should definitely be its own module.

…

On Tue, Nov 6, 2018 at 4:18 PM Jean de Klerk ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In go.sum <#111 (comment)>: > @@ -0,0 +1,26 @@ +cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= Yikes. Yeah. I'll go make the relevant mod files. The path is: genproto -> grpc -> oauth2 -> cloud.google.com/go/compute/metadata — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARoHZQpK9EOcVUHtR1ORIDnDLB-Cp5fvks5usibhgaJpZM4YREwf> .

[pongad]

Please remove "internal" from description as @broady suggested, but LGTM.