update from googleapis #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yeah, I have 3.5.1. Each run of the generator I try to update my protoc version, though. What do you mean by "sync"? Is always using latest version a reasonable strategy? |
|
I don't mean always using latest, but I think that people who generate into this repo should probably be using the same version :) |
|
Right; is there harm in that version always being latest? |
|
I think latest version should be fine. For this PR specifically, something seem to have broken go1.6. I'll investigate. |
|
It's the sys/unix thing. See ongoing conversation at golang/go#26576 (comment) |
jeanbza
approved these changes
Jul 26, 2018
gRPC imports golang.org/x/sys/unix which currently does not build on go1.6. Depending on how compatibility story plays out, we'll either drop 1.6 support or add back 1.6 CI. This commit also slightly changes the CI version "structure". We previously list all Go versions to test against. This commit makes us test against 1.7 and the latest version. This means we don't have to manually bump version when new releases come out. We have to be doing something really strange if we build against 1.7 and 1.10, but not 1.8 and 1.9.
hsanjuan
pushed a commit
to gxed/go-genproto-googleapis-rpc
that referenced
this pull request
Jan 30, 2019
* disable go1.6 gRPC imports golang.org/x/sys/unix which currently does not build on go1.6. Depending on how compatibility story plays out, we'll either drop 1.6 support or add back 1.6 CI. This commit also slightly changes the CI version "structure". We previously list all Go versions to test against. This commit makes us test against 1.7 and the latest version. This means we don't have to manually bump version when new releases come out. We have to be doing something really strange if we build against 1.7 and 1.10, but not 1.8 and 1.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of diffs here. I think this is because I'm generating these with protoc version 3.6.0. @jadekler do you think we should sync our protoc version?