Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response field to HttpRule #87

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Add response field to HttpRule #87

merged 2 commits into from
Aug 8, 2018

Conversation

doroginin
Copy link
Contributor

@doroginin doroginin commented Jul 30, 2018 •
edited
Loading

@doroginin doroginin requested review from jba and pongad as code owners July 30, 2018 10:08
@doroginin doroginin force-pushed the httprule-with-response branch from e44b896 to 8126e81 Compare July 30, 2018 13:40
@doroginin doroginin mentioned this pull request Jul 31, 2018
Merged
@pongad
Copy link
Contributor

pongad commented Jul 31, 2018

@doroginin I'm a little confused by this change. How is this file generated? There's no response_body field in https://github.com/googleapis/googleapis/blob/master/google/api/http.proto

@doroginin
Copy link
Contributor Author

This is already in http.proto. See: googleapis/googleapis#512 and googleapis/googleapis@3544ab1

@doroginin doroginin force-pushed the httprule-with-response branch from c7bf9b3 to 557b016 Compare August 8, 2018 10:59
@doroginin doroginin mentioned this pull request Aug 8, 2018
Closed
@pongad pongad merged commit 383e8b2 into googleapis:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jba jba Awaiting requested review from jba

@pongad pongad Awaiting requested review from pongad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doroginin @pongad