Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth tests lacking #805

Closed
chrisdunelm opened this issue Aug 9, 2016 · 1 comment
Closed

Auth tests lacking #805

chrisdunelm opened this issue Aug 9, 2016 · 1 comment
Assignees
@chrisdunelm

Comments

@chrisdunelm
Copy link
Contributor

More tests for ServiceAccountCredential (and probably other auth classes) needed.
e.g. ServiceAccountCredential.Initializer.FromCertificate() isn't tested at all.
e.g. ServiceAccountCredential.Initializer.FromPrivateKey() test doesn't check that the credential is valid.
etc...
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Aug 11, 2016
@chrisdunelm
NetStandard improvements
6565630 
Support ServiceAccountCredentials in netstandard, although without initialization from X509 certificate. Fixes googleapis#797.

googleapis#805 adds tests for valid AccessToken from ServiceAccountCredential.

Fixed signing in netstandard builds so InternalsVisibleTo now works. Enabled all tests in netstandard that previously were disabled due to internal access.
@chrisdunelm chrisdunelm mentioned this issue Aug 11, 2016
Merged
chrisdunelm added a commit that referenced this issue Aug 11, 2016
@chrisdunelm
NetStandard improvements (#806)
b98d1e3 
* NetStandard improvements

Support ServiceAccountCredentials in netstandard, although without initialization from X509 certificate. Fixes #797.

#805 adds tests for valid AccessToken from ServiceAccountCredential.

Fixed signing in netstandard builds so InternalsVisibleTo now works. Enabled all tests in netstandard that previously were disabled due to internal access.
@chrisdunelm
Copy link
Contributor Author

We now have integration tests that test Service and User credentials. It's not perfect, but much improved; so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdunelm chrisdunelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisdunelm