Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unregister CancellationToken, and fix exception handling on cancellation #1023

Merged
merged 1 commit into from
May 30, 2017
Merged

Unregister CancellationToken, and fix exception handling on cancellation #1023

merged 1 commit into from
May 30, 2017

Conversation

chrisdunelm
Copy link
Contributor

Fixes #1022

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2017
jskeet
jskeet approved these changes May 30, 2017
View reviewed changes
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming disposing of the CancellationTokenRegistration really unregisters... the docs aren't terribly clear.

@chrisdunelm
Copy link
Contributor Author

The remarks section states that disposing unregisters the callback :)

@chrisdunelm chrisdunelm merged commit 756c4e5 into googleapis:v127wip May 30, 2017
@chrisdunelm chrisdunelm deleted the unregistertoken branch May 30, 2017 19:05
chrisdunelm added a commit that referenced this pull request Jun 1, 2017
@chrisdunelm
Merge v127wip branch into master (#1033)
364ef9d 
* Provide synchronous access to default credentials (#1018)

Fixes #652

* Validate application name (#1019)

Fixes #729.

* Add download method that returns final download status (#1020)

Fixes #982.

* Support range downloads in generated code (#1021)

Fixes #981

* Unregister CancellationToken, and fix exception handling on cancellation (#1023)

Fixes #1022

* Clarify NET Core support (#1027)

Fixes #1025

* Update version v1.26.2 -> v1.27.0 (#1028)

* Support JWT validation (#1026)

Fixes #920

* Real JWT validation integration test (#1032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees

@jskeet jskeet

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdunelm @jskeet @googlebot