Allow null Scopes in ExchangeCodeForTokenAsync() #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, using an initializer with Scopes set to null would crash when CreateAuthorizationCodeRequest() was called. Now, the null Scopes propogates safely through as a null Scope for AuthorizationCodeRequestUrl. This is necessary because some OAuth sites do not recognize the "scope" parameter and will return an error instead of the authorization token if the URL contains it. I have updated the tests and added one for the default authorization code request.
Added missing code and test for the ExchangeCodeForTokenAsync() method as well.
googlebot
added
the
cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the same check and a test for ExchangeCodeForTokenAsync() in the second CL.