Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTOTYPE: Auth separation #2405

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

PROTOTYPE: Auth separation #2405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3fe035b
Detach Google.Apis.Auth from Google.Apis
jskeet May 15, 2023
57c9f1f
Extract out "request with a credential"
jskeet May 15, 2023
e96de52
Remove HttpClientFactory and associated classes
jskeet May 15, 2023
a6d6c45
Remove request-building code
jskeet May 15, 2023
3dc9b11
Remove FileDataStore
jskeet May 15, 2023
5f2d31c
Remove unused classes
jskeet May 15, 2023
d6e692b
Remove NewtonsoftJsonSerializer
jskeet May 15, 2023
0ddb19b
Remove more unused code
jskeet May 15, 2023
7c6920d
Remove more unused code.
jskeet May 15, 2023
2120450
More unused code.
jskeet May 15, 2023
fe48aaa
Add notes about what could be hidden/removed, potentially
jskeet May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Src/Support/Google.Apis.Auth/ExistingDependencies/ExponentialBackOffInitializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ limitations under the License.
*/

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

// ExponentialBackOffInitializer could be internal to Google.Apis.Auth (with code duplication).
// We add it to the AuthorizationCodeFlow and ServiceCredential, but we don't expose it.
// ExponentialBackOffPolicy is exposed via the DefaultExponentialBackOffPolicy propert in AuthorizationCodeFlow and ExternalAccountCredential.

namespace Google.Apis.Http
{
Expand Down
3 changes: 3 additions & 0 deletions Src/Support/Google.Apis.Auth/ExistingDependencies/GoogleApiException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ You may obtain a copy of the License at
limitations under the License.
*/

// Note: the only reference to this is in ServiceAccountCredential. If we throw a different exception,
// e.g. InvalidOperationException, we could remove GoogleApiException, SingleError and RequestError.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With some of the initiatives around making errors more actionable I'd still expect things to move in the direction of using specific exception types with structured error messages, even for auth endpoints.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. We should work out what to do on that front then; but it's worth at least being aware that this is the only current usage.


using System;
using System.Net;

Expand Down