-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROTOTYPE: Auth separation #2405
Open
jskeet
wants to merge
11
commits into
googleapis:main
Choose a base branch
from
jskeet:auth-separation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3fe035b
Detach Google.Apis.Auth from Google.Apis
jskeet 57c9f1f
Extract out "request with a credential"
jskeet e96de52
Remove HttpClientFactory and associated classes
jskeet a6d6c45
Remove request-building code
jskeet 3dc9b11
Remove FileDataStore
jskeet 5f2d31c
Remove unused classes
jskeet d6e692b
Remove NewtonsoftJsonSerializer
jskeet 0ddb19b
Remove more unused code
jskeet 7c6920d
Remove more unused code.
jskeet 2120450
More unused code.
jskeet fe48aaa
Add notes about what could be hidden/removed, potentially
jskeet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
100 changes: 0 additions & 100 deletions
100
Src/Support/Google.Apis.Auth/ExistingDependencies/JsonExplicitNull.cs
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
Src/Support/Google.Apis.Auth/ExistingDependencies/JsonExplicitNullAttribute.cs
This file was deleted.
Oops, something went wrong.
231 changes: 0 additions & 231 deletions
231
Src/Support/Google.Apis.Auth/ExistingDependencies/NewtonsoftJsonSerializer.cs
This file was deleted.
Oops, something went wrong.
19 changes: 19 additions & 0 deletions
19
Src/Support/Google.Apis.Auth/ExistingDependencies/ReplacementSerializer.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
using Google.Apis.Auth.OAuth2; | ||
using System; | ||
using System.IO; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
|
||
namespace Google.Apis.Auth.ExistingDependencies; | ||
|
||
// The replacement for NewtonsoftJsonSerializer | ||
internal class ReplacementSerializer | ||
{ | ||
internal static string Serialize<T>(T value) => default; | ||
|
||
internal static T Deserialize<T>(string json) => default; | ||
|
||
public static Task<T> DeserializeAsync<T>(Stream stream, CancellationToken cancellationToken) => default; | ||
|
||
public static T Deserialize<T>(Stream stream) => default; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea to take a dependency on System.Text.Json or to just serialize/deserialize by hand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no opinion on that at the moment :)