Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing OutOfRangeArgument exception when login in windows phone #751

Merged
merged 1 commit into from
May 26, 2016

Conversation

mohdimas
Copy link

Not that sure if this happens to everyone, but I experienced crash whenever attempting OAuth in windows phone 8

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 25, 2016
@chrsmith
Copy link
Contributor

Sorry you ran into the bug. Your PR looks good. I just need you to sign the CLA and reply with "I signed it!"

Thank you for taking the time to submit the patch!

@mohdimas
Copy link
Author

Ok I signed it. Thanks

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 26, 2016
@chrsmith chrsmith merged commit 4072c72 into googleapis:master May 26, 2016
@chrsmith
Copy link
Contributor

Thanks! This will be built and new packages will be published to NuGet in the next week or so.

@mohdimas
Copy link
Author

Great, thanks! looking forward to it.

@chrisdunelm
Copy link
Contributor

This is built, and the new packages are available on NuGet as version 1.13.1.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants