NetStandard1.3 #769
Merged
NetStandard1.3 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Additionally target NetStandard1.3 in support libraries
| @@ -0,0 +1,274 @@ | |||
| /* | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
A few comments, but generally very happy to see this. |
| public Task<AuthorizationCodeResponseUrl> ReceiveCodeAsync(AuthorizationCodeRequestUrl url, | ||
| CancellationToken taskCancellationToken) | ||
| { | ||
| var tcs = new TaskCompletionSource<AuthorizationCodeResponseUrl>(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Closed
|
PTAL |
| @@ -0,0 +1,9 @@ | |||
| using System; | |||
|
|
|||
| namespace Google.Compatibility | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Just a question about the compat shim that you wrote. Other than that it looks good to me. |
chrisdunelm
added a commit
that referenced
this pull request
Aug 4, 2016
* NetStandard1.3 (#769) Adds netstandard1.3 support to the support libraries. Initial commit for #695 * Generated libraries target netstandard1.3 (#772) #695 * Fix NetStandard build (#773) Perform nuget restore for all NetStandard projects before build * Netcore tests (#774) Adding scripts, and project.json definitions for .NET Core test projects. The .NET Core projects only test the .NET Core compatible code. * Improve build (#782) Add NuGet.Config; use local package repository for all builds; fix XML comment issue * Tidy up NetStandard1.3 build gened libs (#783) Fix nuget restore for netstandard1.3, and improve .proj files * Fix support library dependecies (#784) Replace NetStandard.Library deps with explicit dependency list * Netcore test improvements (#788) * Improve .NET core testing Enable ~100 more GoogleApis.Tests test-cases in .NET core. Tidy up project.json's. Remove unneeded Moq & Ionic.ZLib dependencies from test project. Tidy up run_tests_dotnetcore.bat. * Authtest improvements Enable all auth tests in NET core, by using alpha Moq support for core. * Adding travis runner (#789) * Adding the test runner container. * Adding the script to run the tests in a container. * Fixing NuGet.Config to use v2 of the Nuget protocol. * Removing the unnecessary files. (#790) * Better NET Core testing (#792) * Better NET Core testing Implement a minimal HttpListener so all HTTP-based tests can now run on core. Remove NET core tests for the moment that require internal access to libraries Sign netstandard libraries Delete cached Google.* packages before restoring NET Core tests * Appveyor support for the repo. (#793) * Remove ServiceAccountCredentials from netstandard (#794) Due to missing platform support. Also temporarily remove tests that run slowly on appveyor. * Update version 1.14.1 -> 1.15.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally target NetStandard1.3 in support libraries.
This PR does not include testing the NET Core libraries, or NetStandard1.3 support in generated libraries. They will follow.
Note that this PR is merging to the netcore branch, not master. When NetStandard1.3 is fully supported and tested it will be merged into master.