Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log4net dependency #890

Merged
merged 4 commits into from
Dec 22, 2016
Merged

log4net dependency #890

merged 4 commits into from
Dec 22, 2016

Conversation

phnx47
Copy link
Contributor

@phnx47 phnx47 commented Dec 22, 2016

  • Move Log4NetLogger.cs from GoogleApis.DotNet4 to GoogleApis.Tests.
  • Remove log4net dependency from GoogleApis.DotNet4

- Remove log4net dependency from GoogleApis.DotNet4
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 22, 2016
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 22, 2016
@phnx47 phnx47 mentioned this pull request Dec 22, 2016
@phnx47
Copy link
Contributor Author

phnx47 commented Dec 22, 2016

I signed it!

@chrisdunelm chrisdunelm merged commit 7ce7555 into googleapis:master Dec 22, 2016
@chrisdunelm
Copy link
Contributor

Thanks for this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants