Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a convenience method to obtain a GoogleCredential from a JSON string #893

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Jan 3, 2017

Existing private *FromJson methods have been renamed for clarity.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 3, 2017
@jskeet
Copy link
Collaborator Author

jskeet commented Jan 3, 2017

I don't understand the AppVeyor failure here, but I can't restart it myself...

Copy link
Contributor

@chrisdunelm chrisdunelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the appveyor failure isn't real.
LGTM

@jskeet
Copy link
Collaborator Author

jskeet commented Jan 4, 2017

The AppVeyor issue certainly wouldn't have been caused by this change, as it's at the nuget restore phase. Merging - which will trigger another AppVeyor build, I believe.

@jskeet jskeet merged commit c171ffb into googleapis:master Jan 4, 2017
@jskeet jskeet deleted the from-json branch January 4, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants