Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google.golang.org/api/integration-tests/byoid: TestConfigurableTokenLifetime failed #1783

Closed
flaky-bot bot opened this issue Dec 14, 2022 · 1 comment · Fixed by #1797
Closed

google.golang.org/api/integration-tests/byoid: TestConfigurableTokenLifetime failed #1783

flaky-bot bot opened this issue Dec 14, 2022 · 1 comment · Fixed by #1797
Assignees
@codyoss
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 14, 2022

Note: #1765 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: c58bf4c
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:449: Expiry time not set correctly.  Got 2022-12-14 21:17:08 +0000 UTC, want 2022-12-14 21:17:07.95124369 +0000 UTC m=+2802.148128797
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 14, 2022
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Dec 14, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 14, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (c58bf4c), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

codyoss added a commit to codyoss/google-api-go-client that referenced this issue Jan 3, 2023
@codyoss
test: add buffer to both sides of token expiry validation
f610a7e 
This helps account for skew and timing issues.

Fixes: googleapis#1783
@codyoss codyoss mentioned this issue Jan 3, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 3, 2023
@codyoss
test: add buffer to both sides of token expiry validation (#1797)
ddb5c65 
This helps account for skew and timing issues.

Fixes: #1783
@flaky-bot flaky-bot bot mentioned this issue Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add buffer to both sides of token expiry validation codyoss/google-api-go-client
1 participant
@codyoss