-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: remove forced dependency on main google-cloud-go module #2559
Comments
Can you explicitly document what these are? |
At
|
🤖 I have created a release *beep* *boop* --- ## [0.177.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.176.1...v0.177.0) (2024-04-30) ### Features * **all:** Auto-regenerate discovery clients ([#2548](https://togithub.com/googleapis/google-api-go-client/issues/2548)) ([32a5d10](https://togithub.com/googleapis/google-api-go-client/commit/32a5d10b1870bacb93fdf065e5ce7923c04039e8)) * **all:** Auto-regenerate discovery clients ([#2550](https://togithub.com/googleapis/google-api-go-client/issues/2550)) ([f9bf96d](https://togithub.com/googleapis/google-api-go-client/commit/f9bf96df3a9a7ee9eb5b4b01c60d50f4c70e45c9)) * **all:** Auto-regenerate discovery clients ([#2551](https://togithub.com/googleapis/google-api-go-client/issues/2551)) ([4418f5f](https://togithub.com/googleapis/google-api-go-client/commit/4418f5fc551ce9a1edda277ddf483f3dd596d9aa)) * **all:** Auto-regenerate discovery clients ([#2553](https://togithub.com/googleapis/google-api-go-client/issues/2553)) ([2f46e14](https://togithub.com/googleapis/google-api-go-client/commit/2f46e14ff3836ec2ed0e9b08c33b3ec3d29e707b)) * **all:** Auto-regenerate discovery clients ([#2556](https://togithub.com/googleapis/google-api-go-client/issues/2556)) ([fb153c0](https://togithub.com/googleapis/google-api-go-client/commit/fb153c030eb62f149abff30e6948ea1933a9034c)) * Reduce code size by 29% ([#2544](https://togithub.com/googleapis/google-api-go-client/issues/2544)) ([2f2505b](https://togithub.com/googleapis/google-api-go-client/commit/2f2505b83d909fafc4dcf24aff9bb6eb3b7333d7)) ### Bug Fixes * Split large compute file up ([#2546](https://togithub.com/googleapis/google-api-go-client/issues/2546)) ([1b6db6c](https://togithub.com/googleapis/google-api-go-client/commit/1b6db6c4446668599f8db8edda2dde85d7b6015d)) * Temp patch cloud.google.com/go ambiguity ([#2560](https://togithub.com/googleapis/google-api-go-client/issues/2560)) ([3eb92f1](https://togithub.com/googleapis/google-api-go-client/commit/3eb92f1acf25ec8ac4eeb0fa75dbb04a10db36e0)), refs [#2543](https://togithub.com/googleapis/google-api-go-client/issues/2543) [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
I believe the soure for these issue is opencensus outdated imports of really old version of our libraries, genproto. Once we drop that dep we should test removing these workarounds. Updates: googleapis#2559 Fixes: googleapis#2613
🤖 I have created a release *beep* *boop* --- ## [0.183.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.182.0...v0.183.0) (2024-06-04) ### Features * **all:** Auto-regenerate discovery clients ([#2611](https://togithub.com/googleapis/google-api-go-client/issues/2611)) ([1de148b](https://togithub.com/googleapis/google-api-go-client/commit/1de148b049cad72efb924df7f3435bcbca7d214f)) * **all:** Auto-regenerate discovery clients ([#2616](https://togithub.com/googleapis/google-api-go-client/issues/2616)) ([5f21214](https://togithub.com/googleapis/google-api-go-client/commit/5f21214e2284f5162d89383f528326325091796c)) * **all:** Auto-regenerate discovery clients ([#2617](https://togithub.com/googleapis/google-api-go-client/issues/2617)) ([08fdd71](https://togithub.com/googleapis/google-api-go-client/commit/08fdd71cae0bbfd16ed7e13a00c8bc7dd596ce94)) * **all:** Auto-regenerate discovery clients ([#2619](https://togithub.com/googleapis/google-api-go-client/issues/2619)) ([c7f1614](https://togithub.com/googleapis/google-api-go-client/commit/c7f161413cf50b50db98ba483afc2f2344e0896f)) * **all:** Auto-regenerate discovery clients ([#2622](https://togithub.com/googleapis/google-api-go-client/issues/2622)) ([0077748](https://togithub.com/googleapis/google-api-go-client/commit/007774894a48d24634ace7b9e09def4d61433f7f)) ### Bug Fixes * Add another temporary dep on genproto ([#2614](https://togithub.com/googleapis/google-api-go-client/issues/2614)) ([4f98211](https://togithub.com/googleapis/google-api-go-client/commit/4f9821115b5b14b2a32a4cdcbbb84bed018dac2c)), refs [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559) [#2613](https://togithub.com/googleapis/google-api-go-client/issues/2613) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | require | minor | `v0.182.0` -> `v0.187.0` | --- ### Release Notes <details> <summary>googleapis/google-api-go-client (google.golang.org/api)</summary> ### [`v0.187.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.187.0) [Compare Source](googleapis/google-api-go-client@v0.186.0...v0.187.0) ##### Features - **all:** Auto-regenerate discovery clients ([#​2655](googleapis/google-api-go-client#2655)) ([1a28e06](googleapis/google-api-go-client@1a28e06)) - **all:** Auto-regenerate discovery clients ([#​2658](googleapis/google-api-go-client#2658)) ([719f988](googleapis/google-api-go-client@719f988)) - **all:** Auto-regenerate discovery clients ([#​2659](googleapis/google-api-go-client#2659)) ([7cd88da](googleapis/google-api-go-client@7cd88da)) - **all:** Auto-regenerate discovery clients ([#​2660](googleapis/google-api-go-client#2660)) ([3ca2f84](googleapis/google-api-go-client@3ca2f84)) - **all:** Auto-regenerate discovery clients ([#​2661](googleapis/google-api-go-client#2661)) ([0a238f5](googleapis/google-api-go-client@0a238f5)) - **all:** Auto-regenerate discovery clients ([#​2663](googleapis/google-api-go-client#2663)) ([6e061ce](googleapis/google-api-go-client@6e061ce)) ##### Bug Fixes - **gensupport:** Wrap chunk upload err for retries ([#​2657](googleapis/google-api-go-client#2657)) ([a758bc1](googleapis/google-api-go-client@a758bc1)) - Pass through gRPC api key option to new auth lib ([#​2664](googleapis/google-api-go-client#2664)) ([e051997](googleapis/google-api-go-client@e051997)) ### [`v0.186.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.186.0) [Compare Source](googleapis/google-api-go-client@v0.185.0...v0.186.0) ##### Features - **all:** Auto-regenerate discovery clients ([#​2641](googleapis/google-api-go-client#2641)) ([72fb128](googleapis/google-api-go-client@72fb128)) - **all:** Auto-regenerate discovery clients ([#​2644](googleapis/google-api-go-client#2644)) ([20ffdd8](googleapis/google-api-go-client@20ffdd8)) - **all:** Auto-regenerate discovery clients ([#​2645](googleapis/google-api-go-client#2645)) ([c1a7681](googleapis/google-api-go-client@c1a7681)) - **all:** Auto-regenerate discovery clients ([#​2648](googleapis/google-api-go-client#2648)) ([1bac79d](googleapis/google-api-go-client@1bac79d)) - **all:** Auto-regenerate discovery clients ([#​2649](googleapis/google-api-go-client#2649)) ([695484b](googleapis/google-api-go-client@695484b)) - **all:** Auto-regenerate discovery clients ([#​2652](googleapis/google-api-go-client#2652)) ([10c47f3](googleapis/google-api-go-client@10c47f3)) - **all:** Auto-regenerate discovery clients ([#​2653](googleapis/google-api-go-client#2653)) ([bc370a7](googleapis/google-api-go-client@bc370a7)) ### [`v0.185.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.185.0) [Compare Source](googleapis/google-api-go-client@v0.184.0...v0.185.0) ##### Features - **all:** Auto-regenerate discovery clients ([#​2636](googleapis/google-api-go-client#2636)) ([51ff8a4](googleapis/google-api-go-client@51ff8a4)) - **all:** Auto-regenerate discovery clients ([#​2638](googleapis/google-api-go-client#2638)) ([0c868b2](googleapis/google-api-go-client@0c868b2)) ##### Bug Fixes - **internal/gensupport:** Update shouldRetry for GCS uploads ([#​2634](googleapis/google-api-go-client#2634)) ([ea513cb](googleapis/google-api-go-client@ea513cb)) ### [`v0.184.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.184.0) [Compare Source](googleapis/google-api-go-client@v0.183.0...v0.184.0) ##### Features - **all:** Auto-regenerate discovery clients ([#​2624](googleapis/google-api-go-client#2624)) ([7fccba6](googleapis/google-api-go-client@7fccba6)) - Regen cloudcommerceprocurement v1 from updated discovery file ([#​2627](googleapis/google-api-go-client#2627)) ([7e30ed2](googleapis/google-api-go-client@7e30ed2)) - Support structpb.Struct as req/resp ([#​2632](googleapis/google-api-go-client#2632)) ([ebc44d1](googleapis/google-api-go-client@ebc44d1)), refs [#​2601](googleapis/google-api-go-client#2601) ##### Bug Fixes - **cba:** Update credsNewAuth to support oauth2 over mTLS ([#​2610](googleapis/google-api-go-client#2610)) ([953f728](googleapis/google-api-go-client@953f728)) ### [`v0.183.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.183.0) [Compare Source](googleapis/google-api-go-client@v0.182.0...v0.183.0) ##### Features - **all:** Auto-regenerate discovery clients ([#​2611](googleapis/google-api-go-client#2611)) ([1de148b](googleapis/google-api-go-client@1de148b)) - **all:** Auto-regenerate discovery clients ([#​2616](googleapis/google-api-go-client#2616)) ([5f21214](googleapis/google-api-go-client@5f21214)) - **all:** Auto-regenerate discovery clients ([#​2617](googleapis/google-api-go-client#2617)) ([08fdd71](googleapis/google-api-go-client@08fdd71)) - **all:** Auto-regenerate discovery clients ([#​2619](googleapis/google-api-go-client#2619)) ([c7f1614](googleapis/google-api-go-client@c7f1614)) - **all:** Auto-regenerate discovery clients ([#​2622](googleapis/google-api-go-client#2622)) ([0077748](googleapis/google-api-go-client@0077748)) ##### Bug Fixes - Add another temporary dep on genproto ([#​2614](googleapis/google-api-go-client#2614)) ([4f98211](googleapis/google-api-go-client@4f98211)), refs [#​2559](googleapis/google-api-go-client#2559) [#​2613](googleapis/google-api-go-client#2613) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjQuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQyNC4zIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: Renovate Bot <renovate-bot@gitea.com> Reviewed-on: https://git.asdf.cafe/abs3nt/gspot/pulls/9
We should be able to remove this without issue once we remove open census as a dep. That is what is causing us issues today. Per debug.md we can do this anytime after Dec 2, 2024. |
This notably also drops opencensus from our indirect deps! Updates: #2559
We need to force a dependency on the
cloud.google.com/go
main module to ensure that the module is resolved unambiguously. The issue encountered in #2543 and present in #2552 (see below) is odd though because we have other dependencies with newer, unambiguous dependencies on this module. These should win out during dep resolution, but they aren't for some reason.Forcing a direct dep on the module resolves the ambiguity but is not an ideal solution.
The text was updated successfully, but these errors were encountered: