Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove forced dependency on main google-cloud-go module #2559

Closed
noahdietz opened this issue Apr 30, 2024 · 3 comments · Fixed by #2908
Closed

deps: remove forced dependency on main google-cloud-go module #2559

noahdietz opened this issue Apr 30, 2024 · 3 comments · Fixed by #2908
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@noahdietz
Copy link
Contributor

We need to force a dependency on the cloud.google.com/go main module to ensure that the module is resolved unambiguously. The issue encountered in #2543 and present in #2552 (see below) is odd though because we have other dependencies with newer, unambiguous dependencies on this module. These should win out during dep resolution, but they aren't for some reason.

Forcing a direct dep on the module resolves the ambiguity but is not an ideal solution.

/root/go/pkg/mod/cloud.google.com/go/auth@v0.3.0/internal/internal.go:31:2: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
	cloud.google.com/go v0.26.0 (/root/go/pkg/mod/cloud.google.com/go@v0.26.0/compute/metadata)
	cloud.google.com/go/compute/metadata v0.3.0 (/root/go/pkg/mod/cloud.google.com/go/compute/metadata@v0.3.0) (compile)
@noahdietz noahdietz added the type: cleanup An internal cleanup or hygiene concern. label Apr 30, 2024
@quartzmo
Copy link
Member

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

@noahdietz
Copy link
Contributor Author

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

At HEAD before forcing the dep:

$ go mod graph | grep ' cloud.google.com/go@'

cloud.google.com/go/compute@v1.20.1 cloud.google.com/go@v0.110.2
cloud.google.com/go/compute@v1.24.0 cloud.google.com/go@v0.112.0
google.golang.org/genproto@v0.0.0-20240227224415-6ceb2ff114de cloud.google.com/go@v0.112.0
google.golang.org/genproto@v0.0.0-20240125205218-1f4bbc51befe cloud.google.com/go@v0.112.0
cloud.google.com/go/accesscontextmanager@v1.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/aiplatform@v1.60.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/apigateway@v1.6.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/apigeeregistry@v0.8.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/appengine@v1.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/artifactregistry@v1.14.7 cloud.google.com/go@v0.111.0
cloud.google.com/go/asset@v1.17.2 cloud.google.com/go@v0.112.0
cloud.google.com/go/assuredworkloads@v1.11.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/automl@v1.13.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/baremetalsolution@v1.2.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/batch@v1.8.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/beyondcorp@v1.0.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/bigquery@v1.59.1 cloud.google.com/go@v0.112.0
cloud.google.com/go/certificatemanager@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/channel@v1.17.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/cloudbuild@v1.15.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/clouddms@v1.7.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/contactcenterinsights@v1.13.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/container@v1.31.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/containeranalysis@v0.11.4 cloud.google.com/go@v0.112.0
cloud.google.com/go/datacatalog@v1.19.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/datafusion@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/datalabeling@v0.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/dataplex@v1.14.2 cloud.google.com/go@v0.112.0
cloud.google.com/go/dataproc/v2@v2.4.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/datastore@v1.15.0 cloud.google.com/go@v0.110.7
cloud.google.com/go/datastream@v1.10.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/deploy@v1.17.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/dialogflow@v1.49.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/documentai@v1.25.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/domains@v0.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/edgecontainer@v1.1.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/errorreporting@v0.3.0 cloud.google.com/go@v0.105.0
cloud.google.com/go/eventarc@v1.13.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/filestore@v1.8.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/firestore@v1.14.0 cloud.google.com/go@v0.110.2
cloud.google.com/go/functions@v1.16.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/gkebackup@v1.3.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/gkehub@v0.14.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/gkemulticloud@v1.1.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/iam@v1.1.6 cloud.google.com/go@v0.112.0
cloud.google.com/go/ids@v1.4.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/lifesciences@v0.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/logging@v1.9.0 cloud.google.com/go@v0.110.8
cloud.google.com/go/longrunning@v0.5.5 cloud.google.com/go@v0.112.0
cloud.google.com/go/managedidentities@v1.6.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/memcache@v1.10.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/metastore@v1.13.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/monitoring@v1.18.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/networkconnectivity@v1.14.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/networkmanagement@v1.9.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/networksecurity@v0.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/notebooks@v1.11.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/optimization@v1.6.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/orchestration@v1.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/osconfig@v1.12.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/pubsub@v1.36.1 cloud.google.com/go@v0.112.0
cloud.google.com/go/pubsublite@v1.8.1 cloud.google.com/go@v0.110.0
cloud.google.com/go/recommendationengine@v0.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/redis@v1.14.2 cloud.google.com/go@v0.111.0
cloud.google.com/go/resourcemanager@v1.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/retail@v1.16.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/run@v1.3.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/security@v1.15.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/securitycenter@v1.24.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/shell@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/spanner@v1.57.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/speech@v1.21.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/storagetransfer@v1.10.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/talent@v1.6.6 cloud.google.com/go@v0.111.0
cloud.google.com/go/texttospeech@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/tpu@v1.6.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/translate@v1.10.1 cloud.google.com/go@v0.112.0
cloud.google.com/go/video@v1.20.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/videointelligence@v1.11.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/vision/v2@v2.8.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/vmmigration@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/vmwareengine@v1.1.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/vpcaccess@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/webrisk@v1.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/workflows@v1.12.4 cloud.google.com/go@v0.111.0
google.golang.org/grpc@v1.19.0 cloud.google.com/go@v0.26.0
google.golang.org/grpc@v1.23.0 cloud.google.com/go@v0.26.0

gcf-merge-on-green bot pushed a commit that referenced this issue Apr 30, 2024
Force dependency on `cloud.google.com/go` main module to resolve ambiguity.

Fixes #2543
Updates #2559
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 30, 2024
🤖 I have created a release *beep* *boop*
---


## [0.177.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.176.1...v0.177.0) (2024-04-30)


### Features

* **all:** Auto-regenerate discovery clients ([#2548](https://togithub.com/googleapis/google-api-go-client/issues/2548)) ([32a5d10](https://togithub.com/googleapis/google-api-go-client/commit/32a5d10b1870bacb93fdf065e5ce7923c04039e8))
* **all:** Auto-regenerate discovery clients ([#2550](https://togithub.com/googleapis/google-api-go-client/issues/2550)) ([f9bf96d](https://togithub.com/googleapis/google-api-go-client/commit/f9bf96df3a9a7ee9eb5b4b01c60d50f4c70e45c9))
* **all:** Auto-regenerate discovery clients ([#2551](https://togithub.com/googleapis/google-api-go-client/issues/2551)) ([4418f5f](https://togithub.com/googleapis/google-api-go-client/commit/4418f5fc551ce9a1edda277ddf483f3dd596d9aa))
* **all:** Auto-regenerate discovery clients ([#2553](https://togithub.com/googleapis/google-api-go-client/issues/2553)) ([2f46e14](https://togithub.com/googleapis/google-api-go-client/commit/2f46e14ff3836ec2ed0e9b08c33b3ec3d29e707b))
* **all:** Auto-regenerate discovery clients ([#2556](https://togithub.com/googleapis/google-api-go-client/issues/2556)) ([fb153c0](https://togithub.com/googleapis/google-api-go-client/commit/fb153c030eb62f149abff30e6948ea1933a9034c))
* Reduce code size by 29% ([#2544](https://togithub.com/googleapis/google-api-go-client/issues/2544)) ([2f2505b](https://togithub.com/googleapis/google-api-go-client/commit/2f2505b83d909fafc4dcf24aff9bb6eb3b7333d7))


### Bug Fixes

* Split large compute file up ([#2546](https://togithub.com/googleapis/google-api-go-client/issues/2546)) ([1b6db6c](https://togithub.com/googleapis/google-api-go-client/commit/1b6db6c4446668599f8db8edda2dde85d7b6015d))
* Temp patch cloud.google.com/go ambiguity ([#2560](https://togithub.com/googleapis/google-api-go-client/issues/2560)) ([3eb92f1](https://togithub.com/googleapis/google-api-go-client/commit/3eb92f1acf25ec8ac4eeb0fa75dbb04a10db36e0)), refs [#2543](https://togithub.com/googleapis/google-api-go-client/issues/2543) [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
codyoss added a commit to codyoss/google-api-go-client that referenced this issue May 31, 2024
I believe the soure for these issue is opencensus outdated imports
of really old version of our libraries, genproto. Once we drop that
dep we should test removing these workarounds.

Updates: googleapis#2559
Fixes: googleapis#2613
gcf-merge-on-green bot pushed a commit that referenced this issue May 31, 2024
I believe the soure for these issue is opencensus outdated imports of really old version of our libraries, genproto. Once we drop that dep we should test removing these workarounds.

Updates: #2559
Fixes: #2613
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 4, 2024
🤖 I have created a release *beep* *boop*
---


## [0.183.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.182.0...v0.183.0) (2024-06-04)


### Features

* **all:** Auto-regenerate discovery clients ([#2611](https://togithub.com/googleapis/google-api-go-client/issues/2611)) ([1de148b](https://togithub.com/googleapis/google-api-go-client/commit/1de148b049cad72efb924df7f3435bcbca7d214f))
* **all:** Auto-regenerate discovery clients ([#2616](https://togithub.com/googleapis/google-api-go-client/issues/2616)) ([5f21214](https://togithub.com/googleapis/google-api-go-client/commit/5f21214e2284f5162d89383f528326325091796c))
* **all:** Auto-regenerate discovery clients ([#2617](https://togithub.com/googleapis/google-api-go-client/issues/2617)) ([08fdd71](https://togithub.com/googleapis/google-api-go-client/commit/08fdd71cae0bbfd16ed7e13a00c8bc7dd596ce94))
* **all:** Auto-regenerate discovery clients ([#2619](https://togithub.com/googleapis/google-api-go-client/issues/2619)) ([c7f1614](https://togithub.com/googleapis/google-api-go-client/commit/c7f161413cf50b50db98ba483afc2f2344e0896f))
* **all:** Auto-regenerate discovery clients ([#2622](https://togithub.com/googleapis/google-api-go-client/issues/2622)) ([0077748](https://togithub.com/googleapis/google-api-go-client/commit/007774894a48d24634ace7b9e09def4d61433f7f))


### Bug Fixes

* Add another temporary dep on genproto ([#2614](https://togithub.com/googleapis/google-api-go-client/issues/2614)) ([4f98211](https://togithub.com/googleapis/google-api-go-client/commit/4f9821115b5b14b2a32a4cdcbbb84bed018dac2c)), refs [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559) [#2613](https://togithub.com/googleapis/google-api-go-client/issues/2613)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
abs3ntdev pushed a commit to abs3ntdev/gspot that referenced this issue Jul 6, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | require | minor | `v0.182.0` -> `v0.187.0` |

---

### Release Notes

<details>
<summary>googleapis/google-api-go-client (google.golang.org/api)</summary>

### [`v0.187.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.187.0)

[Compare Source](googleapis/google-api-go-client@v0.186.0...v0.187.0)

##### Features

-   **all:** Auto-regenerate discovery clients ([#&#8203;2655](googleapis/google-api-go-client#2655)) ([1a28e06](googleapis/google-api-go-client@1a28e06))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2658](googleapis/google-api-go-client#2658)) ([719f988](googleapis/google-api-go-client@719f988))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2659](googleapis/google-api-go-client#2659)) ([7cd88da](googleapis/google-api-go-client@7cd88da))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2660](googleapis/google-api-go-client#2660)) ([3ca2f84](googleapis/google-api-go-client@3ca2f84))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2661](googleapis/google-api-go-client#2661)) ([0a238f5](googleapis/google-api-go-client@0a238f5))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2663](googleapis/google-api-go-client#2663)) ([6e061ce](googleapis/google-api-go-client@6e061ce))

##### Bug Fixes

-   **gensupport:** Wrap chunk upload err for retries ([#&#8203;2657](googleapis/google-api-go-client#2657)) ([a758bc1](googleapis/google-api-go-client@a758bc1))
-   Pass through gRPC api key option to new auth lib ([#&#8203;2664](googleapis/google-api-go-client#2664)) ([e051997](googleapis/google-api-go-client@e051997))

### [`v0.186.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.186.0)

[Compare Source](googleapis/google-api-go-client@v0.185.0...v0.186.0)

##### Features

-   **all:** Auto-regenerate discovery clients ([#&#8203;2641](googleapis/google-api-go-client#2641)) ([72fb128](googleapis/google-api-go-client@72fb128))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2644](googleapis/google-api-go-client#2644)) ([20ffdd8](googleapis/google-api-go-client@20ffdd8))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2645](googleapis/google-api-go-client#2645)) ([c1a7681](googleapis/google-api-go-client@c1a7681))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2648](googleapis/google-api-go-client#2648)) ([1bac79d](googleapis/google-api-go-client@1bac79d))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2649](googleapis/google-api-go-client#2649)) ([695484b](googleapis/google-api-go-client@695484b))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2652](googleapis/google-api-go-client#2652)) ([10c47f3](googleapis/google-api-go-client@10c47f3))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2653](googleapis/google-api-go-client#2653)) ([bc370a7](googleapis/google-api-go-client@bc370a7))

### [`v0.185.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.185.0)

[Compare Source](googleapis/google-api-go-client@v0.184.0...v0.185.0)

##### Features

-   **all:** Auto-regenerate discovery clients ([#&#8203;2636](googleapis/google-api-go-client#2636)) ([51ff8a4](googleapis/google-api-go-client@51ff8a4))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2638](googleapis/google-api-go-client#2638)) ([0c868b2](googleapis/google-api-go-client@0c868b2))

##### Bug Fixes

-   **internal/gensupport:** Update shouldRetry for GCS uploads ([#&#8203;2634](googleapis/google-api-go-client#2634)) ([ea513cb](googleapis/google-api-go-client@ea513cb))

### [`v0.184.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.184.0)

[Compare Source](googleapis/google-api-go-client@v0.183.0...v0.184.0)

##### Features

-   **all:** Auto-regenerate discovery clients ([#&#8203;2624](googleapis/google-api-go-client#2624)) ([7fccba6](googleapis/google-api-go-client@7fccba6))
-   Regen cloudcommerceprocurement v1 from updated discovery file ([#&#8203;2627](googleapis/google-api-go-client#2627)) ([7e30ed2](googleapis/google-api-go-client@7e30ed2))
-   Support structpb.Struct as req/resp ([#&#8203;2632](googleapis/google-api-go-client#2632)) ([ebc44d1](googleapis/google-api-go-client@ebc44d1)), refs [#&#8203;2601](googleapis/google-api-go-client#2601)

##### Bug Fixes

-   **cba:** Update credsNewAuth to support oauth2 over mTLS ([#&#8203;2610](googleapis/google-api-go-client#2610)) ([953f728](googleapis/google-api-go-client@953f728))

### [`v0.183.0`](https://github.com/googleapis/google-api-go-client/releases/tag/v0.183.0)

[Compare Source](googleapis/google-api-go-client@v0.182.0...v0.183.0)

##### Features

-   **all:** Auto-regenerate discovery clients ([#&#8203;2611](googleapis/google-api-go-client#2611)) ([1de148b](googleapis/google-api-go-client@1de148b))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2616](googleapis/google-api-go-client#2616)) ([5f21214](googleapis/google-api-go-client@5f21214))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2617](googleapis/google-api-go-client#2617)) ([08fdd71](googleapis/google-api-go-client@08fdd71))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2619](googleapis/google-api-go-client#2619)) ([c7f1614](googleapis/google-api-go-client@c7f1614))
-   **all:** Auto-regenerate discovery clients ([#&#8203;2622](googleapis/google-api-go-client#2622)) ([0077748](googleapis/google-api-go-client@0077748))

##### Bug Fixes

-   Add another temporary dep on genproto ([#&#8203;2614](googleapis/google-api-go-client#2614)) ([4f98211](googleapis/google-api-go-client@4f98211)), refs [#&#8203;2559](googleapis/google-api-go-client#2559) [#&#8203;2613](googleapis/google-api-go-client#2613)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjQuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQyNC4zIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: Renovate Bot <renovate-bot@gitea.com>
Reviewed-on: https://git.asdf.cafe/abs3nt/gspot/pulls/9
@codyoss
Copy link
Member

codyoss commented Aug 20, 2024

We should be able to remove this without issue once we remove open census as a dep. That is what is causing us issues today. Per debug.md we can do this anytime after Dec 2, 2024.

gcf-merge-on-green bot pushed a commit that referenced this issue Dec 10, 2024
This notably also drops opencensus from our indirect deps!

Updates: #2559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants