Skip to content

all: regen PRs should not need to be manually updated #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codyoss opened this issue Jul 16, 2020 · 3 comments
Closed

all: regen PRs should not need to be manually updated #590

codyoss opened this issue Jul 16, 2020 · 3 comments
Assignees
@codyoss
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@codyoss
Copy link
Member

codyoss commented Jul 16, 2020

For some reason our last couple of nightly regens are adding a dep to our go.mod file that is not really needed. Example #589. I have manually ran go mod tidy on the PR to fix it. Let's figure out why this is happening all of the sudden.
@codyoss codyoss added the type: process A process-related concern. May include testing, release, or the like. label Jul 16, 2020
@codyoss codyoss self-assigned this Jul 16, 2020
@codyoss codyoss mentioned this issue Jul 20, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 20, 2020
@codyoss
chore(internal/kokoro): add Go info to build logs (#595)
933cfd5 
These are nice to have in general. Trying to debug why this script
is updating the go.mod. See #594 as an example PR that is not
right.

Updates: #590
@codyoss
Copy link
Member Author

codyoss commented Jul 21, 2020

The reason why I could not reproduce this locally is because I use 1.14. It seem like changes to the go command in 1.13 limited the number of dependencies that would be auto-updated when running go build or go mod download.

@codyoss
Copy link
Member Author

codyoss commented Jul 21, 2020

Related:

@codyoss codyoss mentioned this issue Jul 24, 2020
Closed
@codyoss
Copy link
Member Author

codyoss commented Sep 11, 2020

This is now complete. PRs now have a static title and are generated with the same version as they are tidied with.

@codyoss codyoss closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(internal/kokoro): switch off of autosynth onto nightly kokoro
1 participant
@codyoss