fix(gensupport): allow initial request for resumable uploads to retry w/ non-nil getBody #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with non-nil getBody
tritone
approved these changes
Sep 20, 2022
rhu713
pushed a commit
to rhu713/google-api-go-client
that referenced
this pull request
Nov 4, 2022
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
rhu713
pushed a commit
to rhu713/google-api-go-client
that referenced
this pull request
Nov 4, 2022
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
rhu713
pushed a commit
to rhu713/google-api-go-client
that referenced
this pull request
Nov 4, 2022
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
rhu713
pushed a commit
to cockroachdb/google-api-go-client
that referenced
this pull request
Nov 4, 2022
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
rhu713
pushed a commit
to cockroachdb/google-api-go-client
that referenced
this pull request
Nov 7, 2022
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
rhu713
pushed a commit
to cockroachdb/google-api-go-client
that referenced
this pull request
Nov 7, 2022
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
rhu713
pushed a commit
to cockroachdb/google-api-go-client
that referenced
this pull request
Nov 17, 2022
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
rhu713
pushed a commit
to cockroachdb/google-api-go-client
that referenced
this pull request
Jan 18, 2023
… w/ non-nil getBody (googleapis#1690) This allows retries when initiating a resumable upload session. Add support in media.go to return a getBody function so the request body can be recreated during retry attempts. Tests pass locally in google-cloud-go/storage Updates googleapis/google-cloud-go#6652 Co-authored-by: Chris Cotter <cjcotter@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows retries when initiating a resumable upload session.
Add support in
media.goto return agetBodyfunction so the request body can be recreated during retry attempts.Tests pass locally in google-cloud-go/storage
Fixes googleapis/google-cloud-go#6652