Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various auth transition bugs #2533

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 19, 2024

  • Better support for oauth2.Credential conversion
  • set quota project when setting tokensource based cred
  • honor SkipValidation option
  • if DefaultEndpointTemplate is not set pass old DefaultEndpoint. As we just do a string replace code works without formatting derective present.
  • simiplfiy poolAdapter calls to delegate more

- Better support for oauth2.Credential conversion
- set quota project when setting tokensource based cred
- honor SkipValidation option
- if DefaultEndpointTemplate is not set pass old DefaultEndpoint.
  As we just do a string replace code works without formatting
  derective present.
- simiplfiy poolAdapter calls to delegate more
@codyoss codyoss marked this pull request as ready for review April 19, 2024 19:03
@codyoss codyoss requested a review from a team as a code owner April 19, 2024 19:03
@codyoss codyoss changed the title fix: various auth transition fixes fix: various auth transition bugs Apr 19, 2024
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 19, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit d64b1d0 into googleapis:main Apr 19, 2024
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 19, 2024
@codyoss codyoss deleted the authy-fixes branch April 19, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants