feat: Async refresh dry run in parallel with sync refresh #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhshkh
changed the title
quartzmo
requested changes
Nov 22, 2024
|
Can this change be made upstream instead with an embedded private option: https://pkg.go.dev/google.golang.org/api/option/internaloption#EmbeddableAdapter |
quartzmo
approved these changes
Nov 26, 2024
No. the token refresh code is deep into this library and not Bigtable. |
mutianf
reviewed
Nov 27, 2024
codyoss
reviewed
Nov 27, 2024
|
@codyoss I don't have permission to merge this. Can you please merge it if there aren't anymore comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal bug : b/372244283
This is being used in Bigtable client
googleapis/google-cloud-go#11066