fix(internaloption): AuthCreds should honor WithoutAuthentication #3166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case the function will return a nil error and a nil credential. This API is currently only used by storage, whom have asked for this usage change. Also, fixed godoc that was not rendering properly before. Internal Bug: 419426629
Member
Author
|
cc @BrennaEpp |
codyoss
added
the
automerge
noahdietz
reviewed
May 22, 2025
gcf-merge-on-green
bot
removed
the
automerge
noahdietz
reviewed
May 27, 2025
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
codyoss
added
the
automerge
noahdietz
approved these changes
May 28, 2025
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 28, 2025
🤖 I have created a release *beep* *boop* --- ## [0.235.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.234.0...v0.235.0) (2025-05-28) ### Features * **all:** Auto-regenerate discovery clients ([#3164](https://togithub.com/googleapis/google-api-go-client/issues/3164)) ([b477d3d](https://togithub.com/googleapis/google-api-go-client/commit/b477d3ddf2cba1eebb519820e501eda37bad1939)) * **all:** Auto-regenerate discovery clients ([#3167](https://togithub.com/googleapis/google-api-go-client/issues/3167)) ([64d566f](https://togithub.com/googleapis/google-api-go-client/commit/64d566f5e436fb4510a8d9b2fe380cb96f40e2b5)) * **all:** Auto-regenerate discovery clients ([#3168](https://togithub.com/googleapis/google-api-go-client/issues/3168)) ([a78a978](https://togithub.com/googleapis/google-api-go-client/commit/a78a978bd20e317cdb8d8502fd6092c5c1f4ac1e)) * **all:** Auto-regenerate discovery clients ([#3169](https://togithub.com/googleapis/google-api-go-client/issues/3169)) ([00cb9ee](https://togithub.com/googleapis/google-api-go-client/commit/00cb9eec626c2bc0b2261f368cd49e10662550a8)) * **all:** Auto-regenerate discovery clients ([#3171](https://togithub.com/googleapis/google-api-go-client/issues/3171)) ([0a9b174](https://togithub.com/googleapis/google-api-go-client/commit/0a9b174fa07419f77d1e136dab96310228bafb78)) * **all:** Auto-regenerate discovery clients ([#3173](https://togithub.com/googleapis/google-api-go-client/issues/3173)) ([1e2b782](https://togithub.com/googleapis/google-api-go-client/commit/1e2b78253e64bf561e82db7a8d9d223544813a0f)) ### Bug Fixes * **internaloption:** AuthCreds should honor WithoutAuthentication ([#3166](https://togithub.com/googleapis/google-api-go-client/issues/3166)) ([d117646](https://togithub.com/googleapis/google-api-go-client/commit/d117646289fa8e6c072f7643df2cb41417190515)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case the function will return a nil error and a nil credential. This API is currently only used by storage, whom have asked for this usage change. Also, fixed godoc that was not rendering properly before.
Internal Bug: 419426629