fix: add version in userAgent requestHeaders #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
elharo
approved these changes
Nov 4, 2019
elharo
suggested changes
Nov 4, 2019
Yes, it should be 1.30.5. That value should be auto incrementing with each release. I'll investigate that separately. |
kolea2
approved these changes
Nov 4, 2019
kolea2
reviewed
Nov 4, 2019
| @@ -126,7 +126,7 @@ protected AbstractGoogleClientRequest(AbstractGoogleClient abstractGoogleClient, | |||
| // application name | |||
| String applicationName = abstractGoogleClient.getApplicationName(); | |||
| if (applicationName != null) { | |||
| requestHeaders.setUserAgent(applicationName + " " + USER_AGENT_SUFFIX); | |||
| requestHeaders.setUserAgent(applicationName + GoogleUtils.VERSION + " " + USER_AGENT_SUFFIX); | |||
There was a problem hiding this comment.
minor - do you want to leave a space or delimiter between application name and version number?
There was a problem hiding this comment.
The space here is correct, as it is a separate entry in the user-agent and the space is required.
BenWhitehead
requested changes
Nov 5, 2019
...ent/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java
Outdated
Show resolved
Hide resolved
…is/services/AbstractGoogleClientRequest.java Co-Authored-By: BenWhitehead <BenWhitehead@users.noreply.github.com>
|
#1419 addresses the VERSION constant skew. It should also fix the line length checkstyle. |
|
I think this is mooted by #1425. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Surface version in the User-Agent header. The change updates the userAgent value to include 'GoogleUtils.VERSION'.