Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use verifyPayload instead of verify to disable duplicate signatu… #2080

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

TimurSadykov
Copy link
Member

@TimurSadykov TimurSadykov commented May 31, 2022

Switching to verifyPayload instead of full verify to avoid duplicate signature verifications.

See the auth library change for more details: googleapis/google-oauth-java-client#892
The above PR required to be released first.

Fixes #2077 ☕️

@TimurSadykov TimurSadykov requested a review from a team as a code owner May 31, 2022 20:22
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 31, 2022
@TimurSadykov TimurSadykov added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 1, 2022
@TimurSadykov TimurSadykov merged commit 003ca44 into googleapis:main Jun 2, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 2, 2022
🤖 I have created a release *beep* *boop*
---


## [1.35.0](v1.34.0...v1.35.0) (2022-06-02)


### Features

* add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#2075](#2075)) ([2b1558d](2b1558d))
* next release from main branch is 1.35.0 ([#2042](#2042)) ([9005d5c](9005d5c))


### Bug Fixes

* **deps:** update dependency com.google.api-client:google-api-client to v1.34.0 ([#2038](#2038)) ([afea56f](afea56f))
* **deps:** update dependency com.google.api-client:google-api-client to v1.34.1 ([#2058](#2058)) ([d1ddb69](d1ddb69))
* **deps:** update dependency com.google.api-client:google-api-client-android to v1.34.1 ([#2059](#2059)) ([54a9a0c](54a9a0c))
* **deps:** update dependency com.google.api-client:google-api-client-appengine to v1.34.1 ([#2061](#2061)) ([872ad59](872ad59))
* **deps:** update dependency com.google.api-client:google-api-client-assembly to v1.34.1 ([#2062](#2062)) ([1a1d1b3](1a1d1b3))
* **deps:** update dependency com.google.api-client:google-api-client-gson to v1.34.1 ([#2064](#2064)) ([3d1a03a](3d1a03a))
* **deps:** update dependency com.google.api-client:google-api-client-jackson2 to v1.34.1 ([#2065](#2065)) ([3502186](3502186))
* **deps:** update dependency com.google.api-client:google-api-client-java6 to v1.34.1 ([#2066](#2066)) ([705e865](705e865))
* **deps:** update dependency com.google.api-client:google-api-client-protobuf to v1.34.1 ([#2068](#2068)) ([ecedb5b](ecedb5b))
* **deps:** update dependency com.google.api-client:google-api-client-servlet to v1.34.1 ([#2070](#2070)) ([15540fe](15540fe))
* **deps:** update dependency com.google.api-client:google-api-client-xml to v1.34.1 ([#2071](#2071)) ([050a269](050a269))
* **deps:** update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.5 ([#2072](#2072)) ([526e103](526e103))
* **deps:** update dependency com.google.cloud:libraries-bom to v25.2.0 ([#2050](#2050)) ([6c48f89](6c48f89))
* **deps:** update dependency com.google.cloud:libraries-bom to v25.3.0 ([#2073](#2073)) ([11dc2bb](11dc2bb))
* **deps:** update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.3 ([#2041](#2041)) ([be65181](be65181))
* **deps:** update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.0 ([#2081](#2081)) ([8684064](8684064))
* use verifyPayload instead of verify to disable duplicate signature check ([#2080](#2080)) ([003ca44](003ca44))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
🤖 I have created a release *beep* *boop*
---


## [1.35.0](v1.34.0...v1.35.0) (2022-06-02)


### Features

* add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#2075](#2075)) ([2b1558d](2b1558d))
* next release from main branch is 1.35.0 ([#2042](#2042)) ([9005d5c](9005d5c))


### Bug Fixes

* **deps:** update dependency com.google.api-client:google-api-client to v1.34.0 ([#2038](#2038)) ([afea56f](afea56f))
* **deps:** update dependency com.google.api-client:google-api-client to v1.34.1 ([#2058](#2058)) ([d1ddb69](d1ddb69))
* **deps:** update dependency com.google.api-client:google-api-client-android to v1.34.1 ([#2059](#2059)) ([54a9a0c](54a9a0c))
* **deps:** update dependency com.google.api-client:google-api-client-appengine to v1.34.1 ([#2061](#2061)) ([872ad59](872ad59))
* **deps:** update dependency com.google.api-client:google-api-client-assembly to v1.34.1 ([#2062](#2062)) ([1a1d1b3](1a1d1b3))
* **deps:** update dependency com.google.api-client:google-api-client-gson to v1.34.1 ([#2064](#2064)) ([3d1a03a](3d1a03a))
* **deps:** update dependency com.google.api-client:google-api-client-jackson2 to v1.34.1 ([#2065](#2065)) ([3502186](3502186))
* **deps:** update dependency com.google.api-client:google-api-client-java6 to v1.34.1 ([#2066](#2066)) ([705e865](705e865))
* **deps:** update dependency com.google.api-client:google-api-client-protobuf to v1.34.1 ([#2068](#2068)) ([ecedb5b](ecedb5b))
* **deps:** update dependency com.google.api-client:google-api-client-servlet to v1.34.1 ([#2070](#2070)) ([15540fe](15540fe))
* **deps:** update dependency com.google.api-client:google-api-client-xml to v1.34.1 ([#2071](#2071)) ([050a269](050a269))
* **deps:** update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.5 ([#2072](#2072)) ([526e103](526e103))
* **deps:** update dependency com.google.cloud:libraries-bom to v25.2.0 ([#2050](#2050)) ([6c48f89](6c48f89))
* **deps:** update dependency com.google.cloud:libraries-bom to v25.3.0 ([#2073](#2073)) ([11dc2bb](11dc2bb))
* **deps:** update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.3 ([#2041](#2041)) ([be65181](be65181))
* **deps:** update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.0 ([#2081](#2081)) ([8684064](8684064))
* use verifyPayload instead of verify to disable duplicate signature check ([#2080](#2080)) ([003ca44](003ca44))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
🤖 I have created a release *beep* *boop*
---


## [1.35.0](v1.34.0...v1.35.0) (2022-06-02)


### Features

* add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#2075](#2075)) ([2b1558d](2b1558d))
* next release from main branch is 1.35.0 ([#2042](#2042)) ([9005d5c](9005d5c))


### Bug Fixes

* **deps:** update dependency com.google.api-client:google-api-client to v1.34.0 ([#2038](#2038)) ([afea56f](afea56f))
* **deps:** update dependency com.google.api-client:google-api-client to v1.34.1 ([#2058](#2058)) ([d1ddb69](d1ddb69))
* **deps:** update dependency com.google.api-client:google-api-client-android to v1.34.1 ([#2059](#2059)) ([54a9a0c](54a9a0c))
* **deps:** update dependency com.google.api-client:google-api-client-appengine to v1.34.1 ([#2061](#2061)) ([872ad59](872ad59))
* **deps:** update dependency com.google.api-client:google-api-client-assembly to v1.34.1 ([#2062](#2062)) ([1a1d1b3](1a1d1b3))
* **deps:** update dependency com.google.api-client:google-api-client-gson to v1.34.1 ([#2064](#2064)) ([3d1a03a](3d1a03a))
* **deps:** update dependency com.google.api-client:google-api-client-jackson2 to v1.34.1 ([#2065](#2065)) ([3502186](3502186))
* **deps:** update dependency com.google.api-client:google-api-client-java6 to v1.34.1 ([#2066](#2066)) ([705e865](705e865))
* **deps:** update dependency com.google.api-client:google-api-client-protobuf to v1.34.1 ([#2068](#2068)) ([ecedb5b](ecedb5b))
* **deps:** update dependency com.google.api-client:google-api-client-servlet to v1.34.1 ([#2070](#2070)) ([15540fe](15540fe))
* **deps:** update dependency com.google.api-client:google-api-client-xml to v1.34.1 ([#2071](#2071)) ([050a269](050a269))
* **deps:** update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.5 ([#2072](#2072)) ([526e103](526e103))
* **deps:** update dependency com.google.cloud:libraries-bom to v25.2.0 ([#2050](#2050)) ([6c48f89](6c48f89))
* **deps:** update dependency com.google.cloud:libraries-bom to v25.3.0 ([#2073](#2073)) ([11dc2bb](11dc2bb))
* **deps:** update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.3 ([#2041](#2041)) ([be65181](be65181))
* **deps:** update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.0 ([#2081](#2081)) ([8684064](8684064))
* use verifyPayload instead of verify to disable duplicate signature check ([#2080](#2080)) ([003ca44](003ca44))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth: Duplicate signature verification check in GoogleIdTokenVerifier
2 participants