Fixing error handling and object conversion for array types #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 29, 2014 15:59
Fixed googleapis#57, by checking for presence of error details before passing them to the exception
Trying to track down this null value issue.
Array and Map types weren't be recursively converted, so we would be returning the raw object. This could lead to nulls or other unexpected data being sent. Should resolve the underlying issue for googleapis#52
|
We'll test it and tell you. If that's true, it would also fix #39 and answer questions on stackoverflow http://stackoverflow.com/questions/21024694/youtubepartner-php-not-found and http://stackoverflow.com/questions/21278909/example-code-not-working-on-php-developers-site |
|
IT WORKS!!! FINALLY! Thanks a lot for your time. It's really amazing see that all the work is really coming to a good end. Works with server authentication (refresh token), but with a previous manual user login. When do you plan that server authentication works alone without manual login be released? BTW, the example rules ok, as well. Thank you!! |
|
It works! Thank you for clean us up the way. We already are moving forward full throttle on connection developing. THANKS! 👍 |
silvolu
added a commit
that referenced
this pull request
Jan 30, 2014
Fixing error handling and object conversion for array types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where array types weren't converting their member objects properly, and an issue with errors for APIs which don't return error details.
Fixes the issue underlying #52 and #57.