-
Notifications
You must be signed in to change notification settings - Fork 265
feat: Add Credential Information to GoogleCredential classes #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zhumin8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few nit comments.
A question on UserCredentials: the design says to use account from credential json if present. I don't see relevant logic in user cred. What is the reason for this?
oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
Outdated
Show resolved
Hide resolved
I missed that part. The account logic should be added now. |
zhumin8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, non-blocking
oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
|
zhumin8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM




See b/360939866 for more info.
Returns a mapping of how the Credential classes were initialized: