Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Aug 11, 2025

See b/360939866 for more info.

Returns a mapping of how the Credential classes were initialized:

  • Source: Where the initialization information came from (Well known file, Env var)
  • Name: User-friendly Credential class name
  • Principal: Credential identity

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 11, 2025
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
@lqiu96 lqiu96 requested a review from zhumin8 August 18, 2025 16:40
@lqiu96 lqiu96 marked this pull request as ready for review August 18, 2025 16:40
@lqiu96 lqiu96 requested review from a team as code owners August 18, 2025 16:40
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few nit comments.
A question on UserCredentials: the design says to use account from credential json if present. I don't see relevant logic in user cred. What is the reason for this?

@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2025
@lqiu96
Copy link
Member Author

lqiu96 commented Aug 27, 2025

LGTM. Just a few nit comments. A question on UserCredentials: the design says to use account from credential json if present. I don't see relevant logic in user cred. What is the reason for this?

I missed that part. The account logic should be added now.

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, non-blocking

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lqiu96 lqiu96 merged commit 5511913 into main Aug 29, 2025
25 of 26 checks passed
@lqiu96 lqiu96 deleted the actionable-errors branch August 29, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants