Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation related to authentication strategy #1085

Closed
sofisl opened this issue Oct 21, 2020 · 1 comment · Fixed by #1653
Closed

fix documentation related to authentication strategy #1085

sofisl opened this issue Oct 21, 2020 · 1 comment · Fixed by #1653
Assignees
Labels
type: docs Improvement to the documentation for an API. type: process A process-related concern. May include testing, release, or the like.

Comments

@sofisl
Copy link
Contributor

sofisl commented Oct 21, 2020

Related to #1084 and #983

How, and in what order of operations, are we authenticating in this library? We have a document describing how environment variables, constructors, etc., operate together, but what about order of operations within the constructor? For example, where do keyfile, credentials, andclientOptions fit in against the wider order of operations for authentication? When should we be trying to get a projectId?

@sofisl sofisl added type: process A process-related concern. May include testing, release, or the like. type: docs Improvement to the documentation for an API. labels Oct 21, 2020
gcf-owl-bot bot added a commit that referenced this issue Jan 13, 2022
Source-Link: googleapis/synthtool@4dfd20a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:2d850512335d7adca3a4b08e02f8e63192978aea88c042dacb3e382aa996ae7c
@danielbankhead
Copy link
Contributor

The projectId part of this request has been partially resolved here (essentially, we'll do a best effort as some APIs do not require it):

For the others, I raised a PR to improve the documentation: #1653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Improvement to the documentation for an API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants