Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove deprecated DeprecatedGetClientOptions #1393

Merged
merged 2 commits into from
Apr 12, 2022
Merged

refactor!: remove deprecated DeprecatedGetClientOptions #1393

merged 2 commits into from
Apr 12, 2022

Conversation

danielbankhead
Copy link
Contributor

  • removed options from GoogleAuth#getClient
  • removed dangling @deprecated from OAuth2Client#refreshAccessToken

@d-goog
refactor!: Clean-up long-deprecated items
9358e7a 
- removed `options` from `GoogleAuth#getClient`
- removed dangling `@deprecated` from `OAuth2Client#refreshAccessToken`
@danielbankhead danielbankhead added priority: p2 Moderately-important priority. Fix may not be included in next release. do not merge Indicates a pull request not ready for merge, due to either quality or timing. semver: major Hint for users that this is an API breaking change. Breaking Change labels Apr 9, 2022
@danielbankhead danielbankhead requested review from a team as code owners April 9, 2022 02:20
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 9, 2022
@bcoe bcoe removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 12, 2022
@bcoe bcoe changed the title refactor!: Clean-up long-deprecated items refactor!: remove deprecated DeprecatedGetClientOptions Apr 12, 2022
@bcoe bcoe merged commit 9c02941 into main Apr 12, 2022
@bcoe bcoe deleted the deprecation-clean-up branch April 12, 2022 20:29
@release-please release-please bot mentioned this pull request Apr 12, 2022
Merged
sai-sunder-s pushed a commit to sai-sunder-s/google-auth-library-nodejs that referenced this pull request Aug 24, 2022
@gcf-owl-bot @SurferJeffAtGoogle
chore(deps): update actions/setup-node action to v3 (googleapis#1393) (…
2c8c44c 
…googleapis#1388)

Co-authored-by: Jeffrey Rennie <rennie@google.com>
Source-Link: googleapis/synthtool@6593fb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:1d25dfefd805b689a2a2356d35a25b13f2f67bcce55400246432c43a42e96214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
Breaking Change priority: p2 Moderately-important priority. Fix may not be included in next release. semver: major Hint for users that this is an API breaking change. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbankhead @bcoe @d-goog